[v2] ni_routing: Check when the file could not be opened

[PATCH v2] ni_routing: Check when the file could not be opened

Ruffalo Lavoisier posted 1 patch 2 months, 3 weeks ago

Diff against v1 v1 v1 v2 v2
Download mbox

drivers/comedi/drivers/ni_routing/tools/convert_c_to_py.c | 5 +++++
1 file changed, 5 insertions(+)

Expand all Fold all

[PATCH v2] ni_routing: Check when the file could not be opened

Posted by Ruffalo Lavoisier 2 months, 3 weeks ago

- After fopen check NULL before using the file pointer use

Signed-off-by: Ruffalo Lavoisier <RuffaloLavoisier@gmail.com>
---

I'm sorry. I think it's dirty because I'm not used to the patch. I'm going to write it all over again and send it to you.

This is just a defense code just in case.

 drivers/comedi/drivers/ni_routing/tools/convert_c_to_py.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/comedi/drivers/ni_routing/tools/convert_c_to_py.c b/drivers/comedi/drivers/ni_routing/tools/convert_c_to_py.c
index d55521b5bdcb..892a66b2cea6 100644
--- a/drivers/comedi/drivers/ni_routing/tools/convert_c_to_py.c
+++ b/drivers/comedi/drivers/ni_routing/tools/convert_c_to_py.c
@@ -140,6 +140,11 @@ int main(void)
 {
 	FILE *fp = fopen("ni_values.py", "w");
 
+	if (fp == NULL) {
+		fprintf(stderr, "Could not open file!");
+		return -1;
+	}
+
 	/* write route register values */
 	fprintf(fp, "ni_route_values = {\n");
 	for (int i = 0; ni_all_route_values[i]; ++i)
-- 
2.43.0