[v2] selftests: mptcp: add time per subtests in TAP output

[PATCH net-next v2 0/5] selftests: mptcp: add time per subtests in TAP output

Matthieu Baerts (NGI0) posted 5 patches 2 months, 3 weeks ago

Diff against v1
Download series mbox

tools/testing/selftests/net/mptcp/diag.sh          |  2 +-
tools/testing/selftests/net/mptcp/mptcp_connect.sh | 17 ++++++++++-------
tools/testing/selftests/net/mptcp/mptcp_join.sh    |  3 ++-
tools/testing/selftests/net/mptcp/mptcp_lib.sh     | 17 ++++++++++++++++-
tools/testing/selftests/net/mptcp/mptcp_sockopt.sh |  1 +
tools/testing/selftests/net/mptcp/pm_netlink.sh    |  2 ++
tools/testing/selftests/net/mptcp/simult_flows.sh  |  1 +
tools/testing/selftests/net/mptcp/userspace_pm.sh  |  1 +
8 files changed, 34 insertions(+), 10 deletions(-)

Expand all Fold all

[PATCH net-next v2 0/5] selftests: mptcp: add time per subtests in TAP output

Posted by Matthieu Baerts (NGI0) 2 months, 3 weeks ago

Patches here add 'time=<N>ms' in the diagnostic data of the TAP output,
e.g.

  ok 1 - pm_netlink: defaults addr list # time=9ms

This addition is useful to quickly identify which subtests are taking a
longer time than the others, or more than expected.

Note that there are no specific formats to follow to show this time
according to the TAP 13, TAP 14 and KTAP specifications, but we follow
the format being parsed by NIPA [1].

Patch 1 modifies mptcp_lib.sh to add this support to all MPTCP
selftests.

Patch 2 removes the now duplicated info in mptcp_connect.sh

Patch 3 slightly improves the precision of the first subtests in all
MPTCP subtests.

Patches 4 and 5 remove duplicated spaces in TAP output, for the TAP
parsers that cannot handle them properly.

Link: https://github.com/linux-netdev/nipa/pull/36
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
Changes in v2:
- Typo in the commit message of patch 2 (Jakub)
- Two additional patches to remove duplicated spaces in TAP output
- Link to v1: https://lore.kernel.org/r/20240902-net-next-mptcp-ksft-subtest-time-v1-0-f1ed499a11b1@kernel.org

---
Matthieu Baerts (NGI0) (5):
      selftests: mptcp: lib: add time per subtests in TAP output
      selftests: mptcp: connect: remote time in TAP output
      selftests: mptcp: reset the last TS before the first test
      selftests: mptcp: diag: remove trailing whitespace
      selftests: mptcp: connect: remove duplicated spaces in TAP output

 tools/testing/selftests/net/mptcp/diag.sh          |  2 +-
 tools/testing/selftests/net/mptcp/mptcp_connect.sh | 17 ++++++++++-------
 tools/testing/selftests/net/mptcp/mptcp_join.sh    |  3 ++-
 tools/testing/selftests/net/mptcp/mptcp_lib.sh     | 17 ++++++++++++++++-
 tools/testing/selftests/net/mptcp/mptcp_sockopt.sh |  1 +
 tools/testing/selftests/net/mptcp/pm_netlink.sh    |  2 ++
 tools/testing/selftests/net/mptcp/simult_flows.sh  |  1 +
 tools/testing/selftests/net/mptcp/userspace_pm.sh  |  1 +
 8 files changed, 34 insertions(+), 10 deletions(-)
---
base-commit: 52fc70a32573707f70d6b1b5c5fe85cc91457393
change-id: 20240902-net-next-mptcp-ksft-subtest-time-a83cec43d894

Best regards,
-- 
Matthieu Baerts (NGI0) <matttbe@kernel.org>