drivers/pmdomain/ti/ti_sci_pm_domains.c | 72 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 72 insertions(+)
The latest (10.x) version of the firmware for the PM co-processor (aka
device manager, or DM) adds support for a "managed" mode, where the DM
firmware will select the specific low power state which is entered
when Linux requests a system-wide suspend.
In this mode, the DM will always attempt the deepest low-power state
available for the SoC.
However, Linux (or OSes running on other cores) may want to constrain
the DM for certain use cases. For example, the deepest state may have
a wakeup/resume latency that is too long for certain use cases. Or,
some wakeup-capable devices may potentially be powered off in deep
low-power states, but if one of those devices is enabled as a wakeup
source, it should not be powered off.
These kinds of constraints are are already known in Linux by the use
of existing APIs such as per-device PM QoS and device wakeup APIs, but
now we need to communicate these constraints to the DM.
For TI SoCs with TI SCI support, all DM-managed devices will be
connected to a TI SCI PM domain. So the goal of this series is to use
the PM domain driver for TI SCI devices to collect constraints, and
communicate them to the DM via the new TI SCI APIs.
This is all managed by TI SCI PM domain code. No new APIs are needed
by Linux drivers. Any device that is managed by TI SCI will be
checked for QoS constraints or wakeup capability and the constraints
will be collected and sent to the DM.
This series depends on the support for the new TI SCI APIs (v10) and
was also tested with this series to update 8250_omap serial support
for AM62x[2].
[1] https://lore.kernel.org/all/20240801195422.2296347-1-msp@baylibre.com
[2] https://lore.kernel.org/all/20240807141227.1093006-1-msp@baylibre.com/
Signed-off-by: Kevin Hilman <khilman@baylibre.com>
---
Changes in v4:
- fixed missing return in wakeirq error path
- updated trailers with reviewed & tested tags
- Link to v3: https://lore.kernel.org/r/20240905-lpm-v6-10-constraints-pmdomain-v3-0-e359cbb39654@baylibre.com
Changes in v3:
- change latency set functions to static void
- Link to v2: https://lore.kernel.org/r/20240819-lpm-v6-10-constraints-pmdomain-v2-0-461325a6008f@baylibre.com
Changes in v2:
- To simplify this version a bit, drop the pmdomain ->power_off()
changes. Constraints only sent during ->suspend() path. The pmdomain
path was an optimization that may be added back later.
- With the above simplification, drop the extra state variables that
had been added to keep track of constraint status.
- Link to v1: https://lore.kernel.org/r/20240805-lpm-v6-10-constraints-pmdomain-v1-0-d186b68ded4c@baylibre.com
---
Kevin Hilman (3):
pmdomain: ti_sci: add per-device latency constraint management
pmdomain: ti_sci: add wakeup constraint management
pmdomain: ti_sci: handle wake IRQs for IO daisy chain wakeups
drivers/pmdomain/ti/ti_sci_pm_domains.c | 72 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 72 insertions(+)
---
base-commit: ad7eb1b6b92ee0c959a0a6ae846ddadd7a79ea64
change-id: 20240802-lpm-v6-10-constraints-pmdomain-f33df5aef449
prerequisite-message-id: <20240904194229.109886-1-msp@baylibre.com>
prerequisite-patch-id: a0efbf22e69d23dba8bb96db4032ca644935709b
prerequisite-patch-id: a9b6a17956ff6a09a6ed19c35df9018e28b5059b
prerequisite-patch-id: 2999da190c1ba63aabecc55fae501d442e4e0d7b
prerequisite-patch-id: 69a741b9c81d7990937483fc481aafa70e67669d
prerequisite-patch-id: 945b15416a011cb40007c5d95561786c1776bb98
Best regards,
--
Kevin Hilman <khilman@baylibre.com>
Hi Kevin Hilman,
On Fri, 06 Sep 2024 09:14:48 -0700, Kevin Hilman wrote:
> The latest (10.x) version of the firmware for the PM co-processor (aka
> device manager, or DM) adds support for a "managed" mode, where the DM
> firmware will select the specific low power state which is entered
> when Linux requests a system-wide suspend.
>
> In this mode, the DM will always attempt the deepest low-power state
> available for the SoC.
>
> [...]
I have applied the following to branch ti-drivers-soc-next on [1].
Thank you!
Ulf, based on your ack[2], I have assumed that you want me to pick
this series up. Let me know if that is not the case and I can drop the
series.
[1/3] pmdomain: ti_sci: add per-device latency constraint management
commit: 7c2c8d2651b5ffaffb2d5f723bd5b0493bd66f36
[2/3] pmdomain: ti_sci: add wakeup constraint management
commit: 5a2d997b1bf8b05379309270063d7b9bd3767dd2
[3/3] pmdomain: ti_sci: handle wake IRQs for IO daisy chain wakeups
commit: e8f35dc8de8c3216d28dab51b962bb31f20934c8
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
[2] https://lore.kernel.org/all/CAPDyKFr9isnz66B+n5y3=QO-ndB05JKZN3kgXO+kXBn7ofcwMw@mail.gmail.com/
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
On Wed, 30 Oct 2024 at 14:01, Nishanth Menon <nm@ti.com> wrote: > > Hi Kevin Hilman, > > On Fri, 06 Sep 2024 09:14:48 -0700, Kevin Hilman wrote: > > The latest (10.x) version of the firmware for the PM co-processor (aka > > device manager, or DM) adds support for a "managed" mode, where the DM > > firmware will select the specific low power state which is entered > > when Linux requests a system-wide suspend. > > > > In this mode, the DM will always attempt the deepest low-power state > > available for the SoC. > > > > [...] > > I have applied the following to branch ti-drivers-soc-next on [1]. > Thank you! > > Ulf, based on your ack[2], I have assumed that you want me to pick > this series up. Let me know if that is not the case and I can drop the > series. Well, that was a while ago. The reason was because there was a dependency to another series [2], when this was posted. If that's not the case anymore, I think it's better to funnel this via my pmdomain tree. Please let me know how to proceed. Kind regards Uffe > > [1/3] pmdomain: ti_sci: add per-device latency constraint management > commit: 7c2c8d2651b5ffaffb2d5f723bd5b0493bd66f36 > [2/3] pmdomain: ti_sci: add wakeup constraint management > commit: 5a2d997b1bf8b05379309270063d7b9bd3767dd2 > [3/3] pmdomain: ti_sci: handle wake IRQs for IO daisy chain wakeups > commit: e8f35dc8de8c3216d28dab51b962bb31f20934c8 > > All being well this means that it will be integrated into the linux-next > tree (usually sometime in the next 24 hours) and sent up the chain during > the next merge window (or sooner if it is a relevant bug fix), however if > problems are discovered then the patch may be dropped or reverted. > > You may get further e-mails resulting from automated or manual testing > and review of the tree, please engage with people reporting problems and > send followup patches addressing any issues that are reported if needed. > > If any updates are required or you are submitting further changes they > should be sent as incremental updates against current git, existing > patches will not be replaced. > > Please add any relevant lists and maintainers to the CCs when replying > to this mail. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git > [2] https://lore.kernel.org/all/CAPDyKFr9isnz66B+n5y3=QO-ndB05JKZN3kgXO+kXBn7ofcwMw@mail.gmail.com/ > -- > Regards, > Nishanth Menon > Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D >
Ulf Hansson <ulf.hansson@linaro.org> writes: > On Wed, 30 Oct 2024 at 14:01, Nishanth Menon <nm@ti.com> wrote: >> >> Hi Kevin Hilman, >> >> On Fri, 06 Sep 2024 09:14:48 -0700, Kevin Hilman wrote: >> > The latest (10.x) version of the firmware for the PM co-processor (aka >> > device manager, or DM) adds support for a "managed" mode, where the DM >> > firmware will select the specific low power state which is entered >> > when Linux requests a system-wide suspend. >> > >> > In this mode, the DM will always attempt the deepest low-power state >> > available for the SoC. >> > >> > [...] >> >> I have applied the following to branch ti-drivers-soc-next on [1]. >> Thank you! >> >> Ulf, based on your ack[2], I have assumed that you want me to pick >> this series up. Let me know if that is not the case and I can drop the >> series. > > Well, that was a while ago. The reason was because there was a > dependency to another series [2], when this was posted. > > If that's not the case anymore, I think it's better to funnel this via > my pmdomain tree. Please let me know how to proceed. The build-time dependency on [2] still exists, and since that was just queued up by Nishanth, I think this series should (still) go along with it to keep things simple. Kevin > Kind regards > Uffe > >> >> [1/3] pmdomain: ti_sci: add per-device latency constraint management >> commit: 7c2c8d2651b5ffaffb2d5f723bd5b0493bd66f36 >> [2/3] pmdomain: ti_sci: add wakeup constraint management >> commit: 5a2d997b1bf8b05379309270063d7b9bd3767dd2 >> [3/3] pmdomain: ti_sci: handle wake IRQs for IO daisy chain wakeups >> commit: e8f35dc8de8c3216d28dab51b962bb31f20934c8 >> >> All being well this means that it will be integrated into the linux-next >> tree (usually sometime in the next 24 hours) and sent up the chain during >> the next merge window (or sooner if it is a relevant bug fix), however if >> problems are discovered then the patch may be dropped or reverted. >> >> You may get further e-mails resulting from automated or manual testing >> and review of the tree, please engage with people reporting problems and >> send followup patches addressing any issues that are reported if needed. >> >> If any updates are required or you are submitting further changes they >> should be sent as incremental updates against current git, existing >> patches will not be replaced. >> >> Please add any relevant lists and maintainers to the CCs when replying >> to this mail. >> >> [1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git >> [2] https://lore.kernel.org/all/CAPDyKFr9isnz66B+n5y3=QO-ndB05JKZN3kgXO+kXBn7ofcwMw@mail.gmail.com/ >> -- >> Regards, >> Nishanth Menon >> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D >>
On 12:43-20241030, Kevin Hilman wrote: > Ulf Hansson <ulf.hansson@linaro.org> writes: > > > On Wed, 30 Oct 2024 at 14:01, Nishanth Menon <nm@ti.com> wrote: > >> > >> Hi Kevin Hilman, > >> > >> On Fri, 06 Sep 2024 09:14:48 -0700, Kevin Hilman wrote: > >> > The latest (10.x) version of the firmware for the PM co-processor (aka > >> > device manager, or DM) adds support for a "managed" mode, where the DM > >> > firmware will select the specific low power state which is entered > >> > when Linux requests a system-wide suspend. > >> > > >> > In this mode, the DM will always attempt the deepest low-power state > >> > available for the SoC. > >> > > >> > [...] > >> > >> I have applied the following to branch ti-drivers-soc-next on [1]. > >> Thank you! > >> > >> Ulf, based on your ack[2], I have assumed that you want me to pick > >> this series up. Let me know if that is not the case and I can drop the > >> series. > > > > Well, that was a while ago. The reason was because there was a > > dependency to another series [2], when this was posted. > > > > If that's not the case anymore, I think it's better to funnel this via > > my pmdomain tree. Please let me know how to proceed. > > The build-time dependency on [2] still exists, and since that was just > queued up by Nishanth, I think this series should (still) go along with > it to keep things simple. Ulf, are you OK with this? If not, I will drop this series from my tree (we will have to skip this cycle) and do the regular merge via your tree once the dependency hits master on rc1. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
On Wed, 30 Oct 2024 at 20:43, Kevin Hilman <khilman@baylibre.com> wrote: > > Ulf Hansson <ulf.hansson@linaro.org> writes: > > > On Wed, 30 Oct 2024 at 14:01, Nishanth Menon <nm@ti.com> wrote: > >> > >> Hi Kevin Hilman, > >> > >> On Fri, 06 Sep 2024 09:14:48 -0700, Kevin Hilman wrote: > >> > The latest (10.x) version of the firmware for the PM co-processor (aka > >> > device manager, or DM) adds support for a "managed" mode, where the DM > >> > firmware will select the specific low power state which is entered > >> > when Linux requests a system-wide suspend. > >> > > >> > In this mode, the DM will always attempt the deepest low-power state > >> > available for the SoC. > >> > > >> > [...] > >> > >> I have applied the following to branch ti-drivers-soc-next on [1]. > >> Thank you! > >> > >> Ulf, based on your ack[2], I have assumed that you want me to pick > >> this series up. Let me know if that is not the case and I can drop the > >> series. > > > > Well, that was a while ago. The reason was because there was a > > dependency to another series [2], when this was posted. > > > > If that's not the case anymore, I think it's better to funnel this via > > my pmdomain tree. Please let me know how to proceed. > > The build-time dependency on [2] still exists, and since that was just > queued up by Nishanth, I think this series should (still) go along with > it to keep things simple. > > Kevin Right, that makes perfect sense to me too. If we discover conflicts, let's deal with them then. [...] Kind regards Uffe
On 11:11-20241031, Ulf Hansson wrote: > On Wed, 30 Oct 2024 at 20:43, Kevin Hilman <khilman@baylibre.com> wrote: > > > > Ulf Hansson <ulf.hansson@linaro.org> writes: > > > > > On Wed, 30 Oct 2024 at 14:01, Nishanth Menon <nm@ti.com> wrote: > > >> > > >> Hi Kevin Hilman, > > >> > > >> On Fri, 06 Sep 2024 09:14:48 -0700, Kevin Hilman wrote: > > >> > The latest (10.x) version of the firmware for the PM co-processor (aka > > >> > device manager, or DM) adds support for a "managed" mode, where the DM > > >> > firmware will select the specific low power state which is entered > > >> > when Linux requests a system-wide suspend. > > >> > > > >> > In this mode, the DM will always attempt the deepest low-power state > > >> > available for the SoC. > > >> > > > >> > [...] > > >> > > >> I have applied the following to branch ti-drivers-soc-next on [1]. > > >> Thank you! > > >> > > >> Ulf, based on your ack[2], I have assumed that you want me to pick > > >> this series up. Let me know if that is not the case and I can drop the > > >> series. > > > > > > Well, that was a while ago. The reason was because there was a > > > dependency to another series [2], when this was posted. > > > > > > If that's not the case anymore, I think it's better to funnel this via > > > my pmdomain tree. Please let me know how to proceed. > > > > The build-time dependency on [2] still exists, and since that was just > > queued up by Nishanth, I think this series should (still) go along with > > it to keep things simple. > > > > Kevin > > Right, that makes perfect sense to me too. If we discover conflicts, > let's deal with them then. oops.. I missed this response. OK, I will let things be. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
Nishanth Menon <nm@ti.com> writes: > On 11:11-20241031, Ulf Hansson wrote: >> On Wed, 30 Oct 2024 at 20:43, Kevin Hilman <khilman@baylibre.com> wrote: >> > >> > Ulf Hansson <ulf.hansson@linaro.org> writes: >> > >> > > On Wed, 30 Oct 2024 at 14:01, Nishanth Menon <nm@ti.com> wrote: >> > >> >> > >> Hi Kevin Hilman, >> > >> >> > >> On Fri, 06 Sep 2024 09:14:48 -0700, Kevin Hilman wrote: >> > >> > The latest (10.x) version of the firmware for the PM co-processor (aka >> > >> > device manager, or DM) adds support for a "managed" mode, where the DM >> > >> > firmware will select the specific low power state which is entered >> > >> > when Linux requests a system-wide suspend. >> > >> > >> > >> > In this mode, the DM will always attempt the deepest low-power state >> > >> > available for the SoC. >> > >> > >> > >> > [...] >> > >> >> > >> I have applied the following to branch ti-drivers-soc-next on [1]. >> > >> Thank you! >> > >> >> > >> Ulf, based on your ack[2], I have assumed that you want me to pick >> > >> this series up. Let me know if that is not the case and I can drop the >> > >> series. >> > > >> > > Well, that was a while ago. The reason was because there was a >> > > dependency to another series [2], when this was posted. >> > > >> > > If that's not the case anymore, I think it's better to funnel this via >> > > my pmdomain tree. Please let me know how to proceed. >> > >> > The build-time dependency on [2] still exists, and since that was just >> > queued up by Nishanth, I think this series should (still) go along with >> > it to keep things simple. >> > >> > Kevin >> >> Right, that makes perfect sense to me too. If we discover conflicts, >> let's deal with them then. > > > oops.. I missed this response. OK, I will let things be. > Oops, 0day bot found a build error in linux-next when CONFIG_PM_SLEEP is not defined[1]. Need to respin to fix this. v5 coming right up.... Kevin [1] https://lore.kernel.org/all/CA+G9fYtioQ22nVr9m22+qyMqUNRsGdA=cFw_j1OUv=x8Pcs-bw@mail.gmail.com/
On 08:35-20241101, Kevin Hilman wrote: > Nishanth Menon <nm@ti.com> writes: > > > On 11:11-20241031, Ulf Hansson wrote: > >> On Wed, 30 Oct 2024 at 20:43, Kevin Hilman <khilman@baylibre.com> wrote: > >> > > >> > Ulf Hansson <ulf.hansson@linaro.org> writes: > >> > > >> > > On Wed, 30 Oct 2024 at 14:01, Nishanth Menon <nm@ti.com> wrote: > >> > >> > >> > >> Hi Kevin Hilman, > >> > >> > >> > >> On Fri, 06 Sep 2024 09:14:48 -0700, Kevin Hilman wrote: > >> > >> > The latest (10.x) version of the firmware for the PM co-processor (aka > >> > >> > device manager, or DM) adds support for a "managed" mode, where the DM > >> > >> > firmware will select the specific low power state which is entered > >> > >> > when Linux requests a system-wide suspend. > >> > >> > > >> > >> > In this mode, the DM will always attempt the deepest low-power state > >> > >> > available for the SoC. > >> > >> > > >> > >> > [...] > >> > >> > >> > >> I have applied the following to branch ti-drivers-soc-next on [1]. > >> > >> Thank you! > >> > >> > >> > >> Ulf, based on your ack[2], I have assumed that you want me to pick > >> > >> this series up. Let me know if that is not the case and I can drop the > >> > >> series. > >> > > > >> > > Well, that was a while ago. The reason was because there was a > >> > > dependency to another series [2], when this was posted. > >> > > > >> > > If that's not the case anymore, I think it's better to funnel this via > >> > > my pmdomain tree. Please let me know how to proceed. > >> > > >> > The build-time dependency on [2] still exists, and since that was just > >> > queued up by Nishanth, I think this series should (still) go along with > >> > it to keep things simple. > >> > > >> > Kevin > >> > >> Right, that makes perfect sense to me too. If we discover conflicts, > >> let's deal with them then. > > > > > > oops.. I missed this response. OK, I will let things be. > > > > Oops, 0day bot found a build error in linux-next when CONFIG_PM_SLEEP is > not defined[1]. Need to respin to fix this. > > v5 coming right up.... > > Kevin > > [1] https://lore.kernel.org/all/CA+G9fYtioQ22nVr9m22+qyMqUNRsGdA=cFw_j1OUv=x8Pcs-bw@mail.gmail.com/ Kevin, Unfortunately, I have chosen to drop the series. We are too late in the window to take the updated series and wait for new regression reports. On the flip side, this will clean up the flow for Ulf to take your V5 since the dependent series should ideally hit rc1 by then. Thanks for addressing the report fast. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
Nishanth Menon <nm@ti.com> writes: > On 08:35-20241101, Kevin Hilman wrote: >> Nishanth Menon <nm@ti.com> writes: >> >> > On 11:11-20241031, Ulf Hansson wrote: >> >> On Wed, 30 Oct 2024 at 20:43, Kevin Hilman <khilman@baylibre.com> wrote: >> >> > >> >> > Ulf Hansson <ulf.hansson@linaro.org> writes: >> >> > >> >> > > On Wed, 30 Oct 2024 at 14:01, Nishanth Menon <nm@ti.com> wrote: >> >> > >> >> >> > >> Hi Kevin Hilman, >> >> > >> >> >> > >> On Fri, 06 Sep 2024 09:14:48 -0700, Kevin Hilman wrote: >> >> > >> > The latest (10.x) version of the firmware for the PM co-processor (aka >> >> > >> > device manager, or DM) adds support for a "managed" mode, where the DM >> >> > >> > firmware will select the specific low power state which is entered >> >> > >> > when Linux requests a system-wide suspend. >> >> > >> > >> >> > >> > In this mode, the DM will always attempt the deepest low-power state >> >> > >> > available for the SoC. >> >> > >> > >> >> > >> > [...] >> >> > >> >> >> > >> I have applied the following to branch ti-drivers-soc-next on [1]. >> >> > >> Thank you! >> >> > >> >> >> > >> Ulf, based on your ack[2], I have assumed that you want me to pick >> >> > >> this series up. Let me know if that is not the case and I can drop the >> >> > >> series. >> >> > > >> >> > > Well, that was a while ago. The reason was because there was a >> >> > > dependency to another series [2], when this was posted. >> >> > > >> >> > > If that's not the case anymore, I think it's better to funnel this via >> >> > > my pmdomain tree. Please let me know how to proceed. >> >> > >> >> > The build-time dependency on [2] still exists, and since that was just >> >> > queued up by Nishanth, I think this series should (still) go along with >> >> > it to keep things simple. >> >> > >> >> > Kevin >> >> >> >> Right, that makes perfect sense to me too. If we discover conflicts, >> >> let's deal with them then. >> > >> > >> > oops.. I missed this response. OK, I will let things be. >> > >> >> Oops, 0day bot found a build error in linux-next when CONFIG_PM_SLEEP is >> not defined[1]. Need to respin to fix this. >> >> v5 coming right up.... >> >> Kevin >> >> [1] https://lore.kernel.org/all/CA+G9fYtioQ22nVr9m22+qyMqUNRsGdA=cFw_j1OUv=x8Pcs-bw@mail.gmail.com/ > > Kevin, > > Unfortunately, I have chosen to drop the series. We are too late in > the window to take the updated series and wait for new regression > reports. On the flip side, this will clean up the flow for Ulf to take > your V5 since the dependent series should ideally hit rc1 by then. > > Thanks for addressing the report fast. OK, thanks Nishanth, I'll work this series through Ulf's pmdomain tree for the next merge window. Kevin
© 2016 - 2024 Red Hat, Inc.