[PATCH RFC/RFT 0/2] arm64: dts: ti: k3-j784s4: Mark tps659413 and children as bootph-all

Andrew Halaney posted 2 patches 2 months, 3 weeks ago
arch/arm64/boot/dts/ti/k3-am69-sk.dts    | 11 +++++++++++
arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 11 +++++++++++
2 files changed, 22 insertions(+)
[PATCH RFC/RFT 0/2] arm64: dts: ti: k3-j784s4: Mark tps659413 and children as bootph-all
Posted by Andrew Halaney 2 months, 3 weeks ago
This series marks tps659413 and its children as bootph-all in order for
the nodes to be accessible during MCU's u-boot SPL.

This in turn is desired since the tps659413 needs its MCU ESM
state machine setup in order for the watchdog to reset the board.

This took me a little while to track down, as enabling the ESM, TPS6594,
etc in u-boot would result in the below boot failure:

    U-Boot SPL 2024.10-rc4-00007-g44b12cbcd1b3-dirty (Sep 06 2024 - 14:25:52 -0500)
    SYSFW ABI: 3.1 (firmware rev 0x0009 '9.2.4--v09.02.04 (Kool Koala)')
    Initialized 4 DRAM controllers
    SPL initial stack usage: 13408 bytes
    ### ERROR ### Please RESET the board ###

Which turns out to actually have failed far earlier in spl_early_init(),
due to these nodes not being accessible in u-boot. That's hard to tell
though since console isn't setup until later (and for that reason I
think spl_early_init()'s return value in j784s4_init.c isn't
evaluated since a panic() at that point would leave a user with *no*
information at all).

I've tested this in conjunction with a u-boot series which I'll link in
a follow-up response on the k3-j784s4-evm. I'd appreciate someone testing
on the k3-am69-sk at a minimum, as it should suffer the same fate if things
aren't setup appropriately.

Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
---
Andrew Halaney (2):
      arm64: dts: ti: k3-j784s4-evm: Mark tps659413 and children as bootph-all
      arm64: dts: ti: k3-am69-sk: Mark tps659413 and children as bootph-all

 arch/arm64/boot/dts/ti/k3-am69-sk.dts    | 11 +++++++++++
 arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 11 +++++++++++
 2 files changed, 22 insertions(+)
---
base-commit: 9aaeb87ce1e966169a57f53a02ba05b30880ffb8
change-id: 20240906-j784s4-tps6594-bootph-19d3f00fb98a

Best regards,
-- 
Andrew Halaney <ahalaney@redhat.com>
Re: [PATCH RFC/RFT 0/2] arm64: dts: ti: k3-j784s4: Mark tps659413 and children as bootph-all
Posted by Andrew Halaney 2 months, 3 weeks ago
On Fri, Sep 06, 2024 at 04:21:01PM GMT, Andrew Halaney wrote:
> This series marks tps659413 and its children as bootph-all in order for
> the nodes to be accessible during MCU's u-boot SPL.
> 
> This in turn is desired since the tps659413 needs its MCU ESM
> state machine setup in order for the watchdog to reset the board.
> 
> This took me a little while to track down, as enabling the ESM, TPS6594,
> etc in u-boot would result in the below boot failure:
> 
>     U-Boot SPL 2024.10-rc4-00007-g44b12cbcd1b3-dirty (Sep 06 2024 - 14:25:52 -0500)
>     SYSFW ABI: 3.1 (firmware rev 0x0009 '9.2.4--v09.02.04 (Kool Koala)')
>     Initialized 4 DRAM controllers
>     SPL initial stack usage: 13408 bytes
>     ### ERROR ### Please RESET the board ###
> 
> Which turns out to actually have failed far earlier in spl_early_init(),
> due to these nodes not being accessible in u-boot. That's hard to tell
> though since console isn't setup until later (and for that reason I
> think spl_early_init()'s return value in j784s4_init.c isn't
> evaluated since a panic() at that point would leave a user with *no*
> information at all).
> 
> I've tested this in conjunction with a u-boot series which I'll link in
> a follow-up response on the k3-j784s4-evm. I'd appreciate someone testing
> on the k3-am69-sk at a minimum, as it should suffer the same fate if things
> aren't setup appropriately.
> 
> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>

Better late than never...

Link: https://lore.kernel.org/u-boot/20240906-j784s4-esm-enable-v1-0-b83b17d5a744@redhat.com/

> ---
> Andrew Halaney (2):
>       arm64: dts: ti: k3-j784s4-evm: Mark tps659413 and children as bootph-all
>       arm64: dts: ti: k3-am69-sk: Mark tps659413 and children as bootph-all
> 
>  arch/arm64/boot/dts/ti/k3-am69-sk.dts    | 11 +++++++++++
>  arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 11 +++++++++++
>  2 files changed, 22 insertions(+)
> ---
> base-commit: 9aaeb87ce1e966169a57f53a02ba05b30880ffb8
> change-id: 20240906-j784s4-tps6594-bootph-19d3f00fb98a
> 
> Best regards,
> -- 
> Andrew Halaney <ahalaney@redhat.com>
>