[v1] mfd: Convert comma to semicolon

[PATCH v1] mfd: Convert comma to semicolon

Posted by Shen Lichuan 1 year, 5 months ago

Replace a comma between expression statements by a semicolon.

Signed-off-by: Shen Lichuan <shenlichuan@vivo.com>
---
 drivers/mfd/atmel-flexcom.c | 2 +-
 drivers/mfd/rk8xx-core.c    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c
index b52f7ffdad35..d5df5466eaf5 100644
--- a/drivers/mfd/atmel-flexcom.c
+++ b/drivers/mfd/atmel-flexcom.c
@@ -95,7 +95,7 @@ static int __maybe_unused atmel_flexcom_resume_noirq(struct device *dev)
 	if (err)
 		return err;
 
-	val = FLEX_MR_OPMODE(ddata->opmode),
+	val = FLEX_MR_OPMODE(ddata->opmode);
 	writel(val, ddata->base + FLEX_MR);
 
 	clk_disable_unprepare(ddata->clk);
diff --git a/drivers/mfd/rk8xx-core.c b/drivers/mfd/rk8xx-core.c
index 39ab114ea669..c95de65c2f12 100644
--- a/drivers/mfd/rk8xx-core.c
+++ b/drivers/mfd/rk8xx-core.c
@@ -618,7 +618,7 @@ static int rk808_power_off(struct sys_off_data *data)
 		bit = DEV_OFF;
 		break;
 	case RK808_ID:
-		reg = RK808_DEVCTRL_REG,
+		reg = RK808_DEVCTRL_REG;
 		bit = DEV_OFF_RST;
 		break;
 	case RK809_ID:
-- 
2.17.1

Re: (subset) [PATCH v1] mfd: Convert comma to semicolon

Posted by Lee Jones 1 year, 4 months ago

On Thu, 05 Sep 2024 17:27:18 +0800, Shen Lichuan wrote:
> Replace a comma between expression statements by a semicolon.
> 
> 

Applied, thanks!

[1/1] mfd: Convert comma to semicolon
      commit: a261888ccbc29d009c66b06ee02a5e4e0573415d

--
Lee Jones [李琼斯]

Re: [PATCH v1] mfd: Convert comma to semicolon

Posted by Nicolas Ferre 1 year, 5 months ago

On 05/09/2024 at 11:27, Shen Lichuan wrote:
> Replace a comma between expression statements by a semicolon.
> 
> Signed-off-by: Shen Lichuan <shenlichuan@vivo.com>
> ---
>   drivers/mfd/atmel-flexcom.c | 2 +-
>   drivers/mfd/rk8xx-core.c    | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c
> index b52f7ffdad35..d5df5466eaf5 100644
> --- a/drivers/mfd/atmel-flexcom.c
> +++ b/drivers/mfd/atmel-flexcom.c
> @@ -95,7 +95,7 @@ static int __maybe_unused atmel_flexcom_resume_noirq(struct device *dev)
>          if (err)
>                  return err;
> 
> -       val = FLEX_MR_OPMODE(ddata->opmode),
> +       val = FLEX_MR_OPMODE(ddata->opmode);

It surely doesn't change the behavior, but it's probably a typo anyway:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> #  for atmel-flexcom.c

Regards,
   Nicolas

>          writel(val, ddata->base + FLEX_MR);
> 
>          clk_disable_unprepare(ddata->clk);

[..]