dm integrity: Convert comma to semicolon

[PATCH] dm integrity: Convert comma to semicolon

Posted by Chen Ni 1 year, 3 months ago

Replace comma between expressions with semicolons.

Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it is seems best to use ';'
unless ',' is intended.

Found by inspection.
No functional change intended.
Compile tested only.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 drivers/md/dm-integrity.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/md/dm-integrity.c b/drivers/md/dm-integrity.c
index b3489d3fe7db..34fa98efa9fa 100644
--- a/drivers/md/dm-integrity.c
+++ b/drivers/md/dm-integrity.c
@@ -1500,15 +1500,15 @@ static void dm_integrity_flush_buffers(struct dm_integrity_c *ic, bool flush_dat
 	if (!ic->meta_dev)
 		flush_data = false;
 	if (flush_data) {
-		fr.io_req.bi_opf = REQ_OP_WRITE | REQ_PREFLUSH | REQ_SYNC,
-		fr.io_req.mem.type = DM_IO_KMEM,
-		fr.io_req.mem.ptr.addr = NULL,
-		fr.io_req.notify.fn = flush_notify,
+		fr.io_req.bi_opf = REQ_OP_WRITE | REQ_PREFLUSH | REQ_SYNC;
+		fr.io_req.mem.type = DM_IO_KMEM;
+		fr.io_req.mem.ptr.addr = NULL;
+		fr.io_req.notify.fn = flush_notify;
 		fr.io_req.notify.context = &fr;
-		fr.io_req.client = dm_bufio_get_dm_io_client(ic->bufio),
-		fr.io_reg.bdev = ic->dev->bdev,
-		fr.io_reg.sector = 0,
-		fr.io_reg.count = 0,
+		fr.io_req.client = dm_bufio_get_dm_io_client(ic->bufio);
+		fr.io_reg.bdev = ic->dev->bdev;
+		fr.io_reg.sector = 0;
+		fr.io_reg.count = 0;
 		fr.ic = ic;
 		init_completion(&fr.comp);
 		r = dm_io(&fr.io_req, 1, &fr.io_reg, NULL, IOPRIO_DEFAULT);
-- 
2.25.1

Re: dm integrity: Convert comma to semicolon

Posted by Mike Snitzer 1 year, 3 months ago

On Thu, Sep 05, 2024 at 10:28:32AM +0800, Chen Ni wrote:
> Replace comma between expressions with semicolons.
> 
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
> 
> Found by inspection.
> No functional change intended.
> Compile tested only.
> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>

I agree, the use of comma is bizarre.  Not sure how that slipped
through but...

Reviewed-by: Mike Snitzer <snitzer@kernel.org>

Re: dm integrity: Convert comma to semicolon

Posted by Mikulas Patocka 1 year, 3 months ago


On Thu, 5 Sep 2024, Mike Snitzer wrote:

> On Thu, Sep 05, 2024 at 10:28:32AM +0800, Chen Ni wrote:
> > Replace comma between expressions with semicolons.
> > 
> > Using a ',' in place of a ';' can have unintended side effects.
> > Although that is not the case here, it is seems best to use ';'
> > unless ',' is intended.
> > 
> > Found by inspection.
> > No functional change intended.
> > Compile tested only.
> > 
> > Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> 
> I agree, the use of comma is bizarre.  Not sure how that slipped
> through but...
> 
> Reviewed-by: Mike Snitzer <snitzer@kernel.org>

Applied, thanks.

I don't know why I used ',' there.

Mikulas