[PATCH net-next v2 1/3] net: dsa: realtek: rtl8365mb: Make use of irq_get_trigger_type()

Vasileios Amoiridis posted 3 patches 1 year, 3 months ago
There is a newer version of this series
[PATCH net-next v2 1/3] net: dsa: realtek: rtl8365mb: Make use of irq_get_trigger_type()
Posted by Vasileios Amoiridis 1 year, 3 months ago
Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
simple irq_get_trigger_type(irq).

Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
---
 drivers/net/dsa/realtek/rtl8365mb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/dsa/realtek/rtl8365mb.c b/drivers/net/dsa/realtek/rtl8365mb.c
index b9674f68b756..ad7044b295ec 100644
--- a/drivers/net/dsa/realtek/rtl8365mb.c
+++ b/drivers/net/dsa/realtek/rtl8365mb.c
@@ -1740,7 +1740,7 @@ static int rtl8365mb_irq_setup(struct realtek_priv *priv)
 	}
 
 	/* Configure chip interrupt signal polarity */
-	irq_trig = irqd_get_trigger_type(irq_get_irq_data(irq));
+	irq_trig = irq_get_trigger_type(irq);
 	switch (irq_trig) {
 	case IRQF_TRIGGER_RISING:
 	case IRQF_TRIGGER_HIGH:
-- 
2.25.1
Re: [PATCH net-next v2 1/3] net: dsa: realtek: rtl8365mb: Make use of irq_get_trigger_type()
Posted by Alvin Šipraga 1 year, 3 months ago
On Wed, Sep 04, 2024 at 05:10:16PM GMT, Vasileios Amoiridis wrote:
> Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
> simple irq_get_trigger_type(irq).
> 
> Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
> ---
>  drivers/net/dsa/realtek/rtl8365mb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Looks like you missed my review here, you can add it :)

Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
Re: [PATCH net-next v2 1/3] net: dsa: realtek: rtl8365mb: Make use of irq_get_trigger_type()
Posted by Vasileios Amoiridis 1 year, 3 months ago
On Wed, Sep 04, 2024 at 03:40:56PM +0000, Alvin Šipraga wrote:
> On Wed, Sep 04, 2024 at 05:10:16PM GMT, Vasileios Amoiridis wrote:
> > Convert irqd_get_trigger_type(irq_get_irq_data(irq)) cases to the more
> > simple irq_get_trigger_type(irq).
> > 
> > Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
> > ---
> >  drivers/net/dsa/realtek/rtl8365mb.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Looks like you missed my review here, you can add it :)
> 
> Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>

Hi Alvin,

Sorry for missing that, but thank you for reminding :)