[v1] net: ftgmac100: Enable TX interrupt to avoid TX timeout

[PATCH] net: ftgmac100: Enable TX interrupt to avoid TX timeout

Posted by Jacky Chou 1 year, 3 months ago

Currently, the driver only enables RX interrupt to handle RX
packets and TX resources. Sometimes there is not RX traffic,
so the TX resource needs to wait for RX interrupt to free.
This situation will toggle the TX timeout watchdog when the MAC
TX ring has no more resources to transmit packets.
Therefore, enable TX interrupt to release TX resources at any time.

Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
---
 drivers/net/ethernet/faraday/ftgmac100.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/faraday/ftgmac100.h b/drivers/net/ethernet/faraday/ftgmac100.h
index 63b3e02fab16..4968f6f0bdbc 100644
--- a/drivers/net/ethernet/faraday/ftgmac100.h
+++ b/drivers/net/ethernet/faraday/ftgmac100.h
@@ -84,7 +84,7 @@
 			    FTGMAC100_INT_RPKT_BUF)
 
 /* All the interrupts we care about */
-#define FTGMAC100_INT_ALL (FTGMAC100_INT_RPKT_BUF  |  \
+#define FTGMAC100_INT_ALL (FTGMAC100_INT_RXTX  |  \
 			   FTGMAC100_INT_BAD)
 
 /*
-- 
2.25.1

Re: [PATCH] net: ftgmac100: Enable TX interrupt to avoid TX timeout

Posted by Jakub Kicinski 1 year, 3 months ago

On Wed, 4 Sep 2024 18:31:16 +0800 Jacky Chou wrote:
> Currently, the driver only enables RX interrupt to handle RX
> packets and TX resources. Sometimes there is not RX traffic,
> so the TX resource needs to wait for RX interrupt to free.
> This situation will toggle the TX timeout watchdog when the MAC
> TX ring has no more resources to transmit packets.
> Therefore, enable TX interrupt to release TX resources at any time.

Please answer Andrew's question (preferably send a v2 with the answer
as part of the commit message). Add a fixes tag, I think this is where
the bug was added?

Fixes: 10cbd6407609 ("ftgmac100: Rework NAPI & interrupts handling")

And when you send v2, please make sure to CC the author (Benjamin).
-- 
pw-bot: cr

Re: [PATCH] net: ftgmac100: Enable TX interrupt to avoid TX timeout

Posted by Andrew Lunn 1 year, 3 months ago

On Wed, Sep 04, 2024 at 06:31:16PM +0800, Jacky Chou wrote:
> Currently, the driver only enables RX interrupt to handle RX
> packets and TX resources. Sometimes there is not RX traffic,
> so the TX resource needs to wait for RX interrupt to free.
> This situation will toggle the TX timeout watchdog when the MAC
> TX ring has no more resources to transmit packets.
> Therefore, enable TX interrupt to release TX resources at any time.

This looks reasonable. FTGMAC100_INT_ALL is used when NAPI polling is
not being used, so the extra interrupts should not cause additional
load.

Is this a fix? How easy is it to trigger the issue?

   Andrew