ionic: Convert comma to semicolon

[PATCH net-next] ionic: Convert comma to semicolon

Posted by Chen Ni 1 year, 3 months ago

Replace comma between expressions with semicolons.

Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it is seems best to use ';'
unless ',' is intended.

Found by inspection.
No functional change intended.
Compile tested only.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c b/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c
index 1ee2f285cb42..528114877677 100644
--- a/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c
+++ b/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c
@@ -312,8 +312,8 @@ static int ionic_lif_filter_add(struct ionic_lif *lif,
 	int err = 0;
 
 	ctx.cmd.rx_filter_add = *ac;
-	ctx.cmd.rx_filter_add.opcode = IONIC_CMD_RX_FILTER_ADD,
-	ctx.cmd.rx_filter_add.lif_index = cpu_to_le16(lif->index),
+	ctx.cmd.rx_filter_add.opcode = IONIC_CMD_RX_FILTER_ADD;
+	ctx.cmd.rx_filter_add.lif_index = cpu_to_le16(lif->index);
 
 	spin_lock_bh(&lif->rx_filters.lock);
 	f = ionic_rx_filter_find(lif, &ctx.cmd.rx_filter_add);
-- 
2.25.1

Re: [PATCH net-next] ionic: Convert comma to semicolon

Posted by Nelson, Shannon 1 year, 3 months ago

On 9/4/2024 1:17 AM, Chen Ni wrote:
> 
> Replace comma between expressions with semicolons.
> 
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
> 
> Found by inspection.
> No functional change intended.
> Compile tested only.
> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>   drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c b/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c
> index 1ee2f285cb42..528114877677 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c
> @@ -312,8 +312,8 @@ static int ionic_lif_filter_add(struct ionic_lif *lif,
>          int err = 0;
> 
>          ctx.cmd.rx_filter_add = *ac;
> -       ctx.cmd.rx_filter_add.opcode = IONIC_CMD_RX_FILTER_ADD,
> -       ctx.cmd.rx_filter_add.lif_index = cpu_to_le16(lif->index),
> +       ctx.cmd.rx_filter_add.opcode = IONIC_CMD_RX_FILTER_ADD;
> +       ctx.cmd.rx_filter_add.lif_index = cpu_to_le16(lif->index);
> 
>          spin_lock_bh(&lif->rx_filters.lock);
>          f = ionic_rx_filter_find(lif, &ctx.cmd.rx_filter_add);
> --
> 2.25.1
> 


Thanks for catching that.

Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>