drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Replace comma between expressions with semicolons.
Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it is seems best to use ';'
unless ',' is intended.
Found by inspection.
No functional change intended.
Compile tested only.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index 815f6b3c79fc..349aa3439502 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -1135,7 +1135,7 @@ static void brcmf_escan_prep(struct brcmf_cfg80211_info *cfg,
offset = offsetof(struct brcmf_scan_params_v2_le, channel_list) +
n_channels * sizeof(u16);
offset = roundup(offset, sizeof(u32));
- length += sizeof(ssid_le) * n_ssids,
+ length += sizeof(ssid_le) * n_ssids;
ptr = (char *)params_le + offset;
for (i = 0; i < n_ssids; i++) {
memset(&ssid_le, 0, sizeof(ssid_le));
--
2.25.1
Chen Ni <nichen@iscas.ac.cn> wrote: > Replace comma between expressions with semicolons. > > Using a ',' in place of a ';' can have unintended side effects. > Although that is not the case here, it is seems best to use ';' > unless ',' is intended. > > Found by inspection. > No functional change intended. > Compile tested only. > > Signed-off-by: Chen Ni <nichen@iscas.ac.cn> > Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com> Patch applied to wireless-next.git, thanks. 4f0568492fc4 wifi: brcmfmac: cfg80211: Convert comma to semicolon -- https://patchwork.kernel.org/project/linux-wireless/patch/20240904074637.1352864-1-nichen@iscas.ac.cn/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
On 9/4/2024 9:46 AM, Chen Ni wrote: > Replace comma between expressions with semicolons. > > Using a ',' in place of a ';' can have unintended side effects. > Although that is not the case here, it is seems best to use ';' > unless ',' is intended. Almost certainly not intended or at least I can not think of a reason for that construct here so without further ado .... > Found by inspection. > No functional change intended. > Compile tested only. Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com> > Signed-off-by: Chen Ni <nichen@iscas.ac.cn> > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
© 2016 - 2026 Red Hat, Inc.