[PATCH v2 0/6] Various 32-bit and test fixes

Ian Rogers posted 6 patches 1 year, 3 months ago
tools/perf/tests/bp_account.c                 |  4 +++-
tools/perf/tests/bp_signal.c                  |  3 ++-
tools/perf/tests/bp_signal_overflow.c         |  3 ++-
tools/perf/tests/parse-events.c               |  3 ++-
.../shell/test_uprobe_from_different_cu.sh    |  7 ++++++
tools/perf/tests/wp.c                         |  5 ++++
tools/perf/util/parse-events.c                | 23 ++++++++++++++++++-
tools/perf/util/parse-events.h                |  2 ++
tools/perf/util/pmus.c                        |  6 ++---
tools/perf/util/time-utils.c                  |  4 ++--
10 files changed, 50 insertions(+), 10 deletions(-)
[PATCH v2 0/6] Various 32-bit and test fixes
Posted by Ian Rogers 1 year, 3 months ago
Running `perf test` as an i386 executable yielded a number of
failures, some of which are addressed here.

The first 2 are straightforward use strtoull issues when parsing a
64-bit quantity in 32-bit land.

The 3rd patch just avoids a fail when `perf probe` isn't compiled in
(in my case as LIBELF wasn't present).

The 4th and 5th cases fix the breakpoint length, on i386 so the
sizeof(long) used matches the kernel's sizeof(long). On aarch64 the
value is change to 4 instead of sizeof(long), ie 8, as future kernels
may make 8 an invalid argument.

The final change addresses i386 watchpoint support not supporting
8-byte values.

v2: Fix a signed comparison build issue with gcc.

Ian Rogers (6):
  perf pmus: Fix name comparisons on 32-bit systems
  perf time-utils: Fix 32-bit nsec parsing
  perf test: Skip uprobe test if probe command isn't present
  perf parse-events: Add default_breakpoint_len helper
  perf parse-events: Vary default_breakpoint_len on i386 and arm64
  perf test: Make watchpoint data 32-bits on i386

 tools/perf/tests/bp_account.c                 |  4 +++-
 tools/perf/tests/bp_signal.c                  |  3 ++-
 tools/perf/tests/bp_signal_overflow.c         |  3 ++-
 tools/perf/tests/parse-events.c               |  3 ++-
 .../shell/test_uprobe_from_different_cu.sh    |  7 ++++++
 tools/perf/tests/wp.c                         |  5 ++++
 tools/perf/util/parse-events.c                | 23 ++++++++++++++++++-
 tools/perf/util/parse-events.h                |  2 ++
 tools/perf/util/pmus.c                        |  6 ++---
 tools/perf/util/time-utils.c                  |  4 ++--
 10 files changed, 50 insertions(+), 10 deletions(-)

-- 
2.46.0.469.g59c65b2a67-goog
Re: [PATCH v2 0/6] Various 32-bit and test fixes
Posted by Arnaldo Carvalho de Melo 1 year, 3 months ago
On Tue, Sep 03, 2024 at 10:06:00PM -0700, Ian Rogers wrote:
> The 4th and 5th cases fix the breakpoint length, on i386 so the
> sizeof(long) used matches the kernel's sizeof(long). On aarch64 the
> value is change to 4 instead of sizeof(long), ie 8, as future kernels
> may make 8 an invalid argument.

Applied these, the others were already in tmp.perf-tools-next, thanks.

- Arnaldo