Add support to AD8460 Waveform Generator DAC

[PATCH v3 0/2] Add support to AD8460 Waveform Generator DAC

Posted by Mariel Tinaco 1 year, 3 months ago

Apply comments for adding support to AD8460 Waveform Generator DAC

ad8460:
  * Fixed errors detected by test bot
  * Applied proper masking of fixed values
  * Applied proper wrapping to get close to 80 chars
  * Applied proper comment formatting
  * Applied proper placement of breaks in switch cases
  * Removed channel properties unused by IIO buffer interface
  * Simplified property getting on probe function
  * Fixed error handlings on probe function
  * Fixed setting of overvoltage, overcurrent and overtemperature ranges;
    If value provided is invalid, default state of the register will not
    be rewritten

Bindings:
  * Dropped unnecessary descriptions
  * Updated property descriptions to describe functionality properly
  * Added multiple selection of values for adi,range-microvolt property
  * Fixed formatting errors to follow DTS coding style
  * Lifted GPIO naming from gpio-consumer-common yaml

Patch:
  * Wrapped patches to 75 chars

Mariel Tinaco (2):
  dt-bindings: iio: dac: add docs for ad8460
  iio: dac: support the ad8460 Waveform DAC

 .../bindings/iio/dac/adi,ad8460.yaml          | 154 +++
 MAINTAINERS                                   |   8 +
 drivers/iio/dac/Kconfig                       |  13 +
 drivers/iio/dac/Makefile                      |   1 +
 drivers/iio/dac/ad8460.c                      | 932 ++++++++++++++++++
 5 files changed, 1108 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/dac/adi,ad8460.yaml
 create mode 100644 drivers/iio/dac/ad8460.c


base-commit: c4b43d8336e52dce6d124e428aa3b71703e62647
-- 
2.34.1

Re: [PATCH v3 0/2] Add support to AD8460 Waveform Generator DAC

Posted by Krzysztof Kozlowski 1 year, 3 months ago

On Wed, Sep 04, 2024 at 10:30:38AM +0800, Mariel Tinaco wrote:
> Apply comments for adding support to AD8460 Waveform Generator DAC
> 
> ad8460:
>   * Fixed errors detected by test bot
>   * Applied proper masking of fixed values
>   * Applied proper wrapping to get close to 80 chars
>   * Applied proper comment formatting
>   * Applied proper placement of breaks in switch cases
>   * Removed channel properties unused by IIO buffer interface
>   * Simplified property getting on probe function
>   * Fixed error handlings on probe function
>   * Fixed setting of overvoltage, overcurrent and overtemperature ranges;
>     If value provided is invalid, default state of the register will not
>     be rewritten
> 
> Bindings:
>   * Dropped unnecessary descriptions
>   * Updated property descriptions to describe functionality properly
>   * Added multiple selection of values for adi,range-microvolt property
>   * Fixed formatting errors to follow DTS coding style
>   * Lifted GPIO naming from gpio-consumer-common yaml

This all happened in v3? Or v2? Please write accurate changelogs.

Best regards,
Krzysztof