[PATCH net-next v2] ptp: ptp_idt82p33: Convert comma to semicolon

Chen Ni posted 1 patch 1 year, 3 months ago
drivers/ptp/ptp_idt82p33.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
[PATCH net-next v2] ptp: ptp_idt82p33: Convert comma to semicolon
Posted by Chen Ni 1 year, 3 months ago
Replace comma between expressions with semicolons.

Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it is seems best to use ';'
unless ',' is intended.

Found by inspection.
No functional change intended.
Compile tested only.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
Changelog:

v1 -> v2:

1. Update commit message.
---
 drivers/ptp/ptp_idt82p33.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/ptp/ptp_idt82p33.c b/drivers/ptp/ptp_idt82p33.c
index 92bb42c43fb2..d5732490ed9d 100644
--- a/drivers/ptp/ptp_idt82p33.c
+++ b/drivers/ptp/ptp_idt82p33.c
@@ -1171,10 +1171,10 @@ static void idt82p33_caps_init(u32 index, struct ptp_clock_info *caps,
 	caps->owner = THIS_MODULE;
 	caps->max_adj = DCO_MAX_PPB;
 	caps->n_per_out = MAX_PER_OUT;
-	caps->n_ext_ts = MAX_PHC_PLL,
-	caps->n_pins = max_pins,
-	caps->adjphase = idt82p33_adjwritephase,
-	caps->getmaxphase = idt82p33_getmaxphase,
+	caps->n_ext_ts = MAX_PHC_PLL;
+	caps->n_pins = max_pins;
+	caps->adjphase = idt82p33_adjwritephase;
+	caps->getmaxphase = idt82p33_getmaxphase;
 	caps->adjfine = idt82p33_adjfine;
 	caps->adjtime = idt82p33_adjtime;
 	caps->gettime64 = idt82p33_gettime;
-- 
2.25.1
Re: [PATCH net-next v2] ptp: ptp_idt82p33: Convert comma to semicolon
Posted by Simon Horman 1 year, 3 months ago
On Wed, Sep 04, 2024 at 09:50:03AM +0800, Chen Ni wrote:
> Replace comma between expressions with semicolons.
> 
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
> 
> Found by inspection.
> No functional change intended.
> Compile tested only.
> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> Changelog:
> 
> v1 -> v2:
> 
> 1. Update commit message.

Thanks for the update.

I checked and I was not able to see any other instances of this
problem in this file.

Reviewed-by: Simon Horman <horms@kernel.org>
Re: [PATCH net-next v2] ptp: ptp_idt82p33: Convert comma to semicolon
Posted by Richard Cochran 1 year, 3 months ago
On Wed, Sep 04, 2024 at 09:50:03AM +0800, Chen Ni wrote:
> Replace comma between expressions with semicolons.
> 
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
> 
> Found by inspection.
> No functional change intended.
> Compile tested only.
> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>

Acked-by: Richard Cochran <richardcochran@gmail.com>