[PATCH 01/15] timers: Rename next_expiry_recalc() to be unique

Anna-Maria Behnsen posted 15 patches 1 year, 3 months ago
There is a newer version of this series
[PATCH 01/15] timers: Rename next_expiry_recalc() to be unique
Posted by Anna-Maria Behnsen 1 year, 3 months ago
next_expiry_recalc is the name of a function as well as the name of a
struct member of struct timer_base. This might lead to confusion.

Rename next_expiry_recalc() to timer_recalc_next_expiry(). No functional
change.

Signed-off-by: Anna-Maria Behnsen <anna-maria@linutronix.de>
---
 kernel/time/timer.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/time/timer.c b/kernel/time/timer.c
index 311ea459b976..5e021a2d8d61 100644
--- a/kernel/time/timer.c
+++ b/kernel/time/timer.c
@@ -1900,7 +1900,7 @@ static int next_pending_bucket(struct timer_base *base, unsigned offset,
  *
  * Store next expiry time in base->next_expiry.
  */
-static void next_expiry_recalc(struct timer_base *base)
+static void timer_recalc_next_expiry(struct timer_base *base)
 {
 	unsigned long clk, next, adj;
 	unsigned lvl, offset = 0;
@@ -2009,7 +2009,7 @@ static unsigned long next_timer_interrupt(struct timer_base *base,
 					  unsigned long basej)
 {
 	if (base->next_expiry_recalc)
-		next_expiry_recalc(base);
+		timer_recalc_next_expiry(base);
 
 	/*
 	 * Move next_expiry for the empty base into the future to prevent an
@@ -2413,7 +2413,7 @@ static inline void __run_timers(struct timer_base *base)
 		 * jiffies to avoid endless requeuing to current jiffies.
 		 */
 		base->clk++;
-		next_expiry_recalc(base);
+		timer_recalc_next_expiry(base);
 
 		while (levels--)
 			expire_timers(base, heads + levels);

-- 
2.39.2
Re: [PATCH 01/15] timers: Rename next_expiry_recalc() to be unique
Posted by Frederic Weisbecker 1 year, 3 months ago
Le Wed, Sep 04, 2024 at 03:04:51PM +0200, Anna-Maria Behnsen a écrit :
> next_expiry_recalc is the name of a function as well as the name of a
> struct member of struct timer_base. This might lead to confusion.
> 
> Rename next_expiry_recalc() to timer_recalc_next_expiry(). No functional
> change.
> 
> Signed-off-by: Anna-Maria Behnsen <anna-maria@linutronix.de>

Reviewed-by: Frederic Weisbecker <frederic@kernel.org>