[v1] selftests: net: convert comma to semicolon

[PATCH] selftests: net: convert comma to semicolon

Chen Ni posted 1 patch 1 year, 3 months ago

Diff against v2
Download mbox

There is a newer version of this series

tools/testing/selftests/net/psock_fanout.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Expand all Fold all

[PATCH] selftests: net: convert comma to semicolon

Posted by Chen Ni 1 year, 3 months ago

Replace a comma between expression statements by a semicolon.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 tools/testing/selftests/net/psock_fanout.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/net/psock_fanout.c b/tools/testing/selftests/net/psock_fanout.c
index 1a736f700be4..4f31e92ebd96 100644
--- a/tools/testing/selftests/net/psock_fanout.c
+++ b/tools/testing/selftests/net/psock_fanout.c
@@ -165,9 +165,9 @@ static void sock_fanout_set_ebpf(int fd)
 	attr.insns = (unsigned long) prog;
 	attr.insn_cnt = ARRAY_SIZE(prog);
 	attr.license = (unsigned long) "GPL";
-	attr.log_buf = (unsigned long) log_buf,
-	attr.log_size = sizeof(log_buf),
-	attr.log_level = 1,
+	attr.log_buf = (unsigned long) log_buf;
+	attr.log_size = sizeof(log_buf);
+	attr.log_level = 1;
 
 	pfd = syscall(__NR_bpf, BPF_PROG_LOAD, &attr, sizeof(attr));
 	if (pfd < 0) {
-- 
2.25.1

Re: [PATCH] selftests: net: convert comma to semicolon

Posted by Simon Horman 1 year, 3 months ago

On Tue, Sep 03, 2024 at 03:45:19PM +0800, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>

As mentioned at [1] I think it would be nice if the patch description
was a bit more descriptive.

[1] https://lore.kernel.org/all/20240903152125.GA4792@kernel.org/