HID: amd_sfh: Convert comma to semicolon

[PATCH] HID: amd_sfh: Convert comma to semicolon

Posted by Chen Ni 1 year, 3 months ago

Replace a comma between expression statements by a semicolon.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c
index 621793d92464..db36d87d5634 100644
--- a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c
+++ b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c
@@ -299,8 +299,8 @@ static void amd_sfh_set_ops(struct amd_mp2_dev *mp2)
 
 	sfh_interface_init(mp2);
 	mp2_ops = mp2->mp2_ops;
-	mp2_ops->clear_intr = amd_sfh_clear_intr_v2,
-	mp2_ops->init_intr = amd_sfh_irq_init_v2,
+	mp2_ops->clear_intr = amd_sfh_clear_intr_v2;
+	mp2_ops->init_intr = amd_sfh_irq_init_v2;
 	mp2_ops->suspend = amd_sfh_suspend;
 	mp2_ops->resume = amd_sfh_resume;
 	mp2_ops->remove = amd_mp2_pci_remove;
-- 
2.25.1

Re: [PATCH] HID: amd_sfh: Convert comma to semicolon

Posted by Jiri Kosina 1 year, 3 months ago

On Tue, 3 Sep 2024, Chen Ni wrote:

> Replace a comma between expression statements by a semicolon.
> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>  drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c
> index 621793d92464..db36d87d5634 100644
> --- a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c
> +++ b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c
> @@ -299,8 +299,8 @@ static void amd_sfh_set_ops(struct amd_mp2_dev *mp2)
>  
>  	sfh_interface_init(mp2);
>  	mp2_ops = mp2->mp2_ops;
> -	mp2_ops->clear_intr = amd_sfh_clear_intr_v2,
> -	mp2_ops->init_intr = amd_sfh_irq_init_v2,
> +	mp2_ops->clear_intr = amd_sfh_clear_intr_v2;
> +	mp2_ops->init_intr = amd_sfh_irq_init_v2;
>  	mp2_ops->suspend = amd_sfh_suspend;
>  	mp2_ops->resume = amd_sfh_resume;

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs

Re: [PATCH] HID: amd_sfh: Convert comma to semicolon

Posted by Basavaraj Natikar 1 year, 3 months ago

On 9/3/2024 8:14 AM, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>  drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c
> index 621793d92464..db36d87d5634 100644
> --- a/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c
> +++ b/drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c
> @@ -299,8 +299,8 @@ static void amd_sfh_set_ops(struct amd_mp2_dev *mp2)
>  
>  	sfh_interface_init(mp2);
>  	mp2_ops = mp2->mp2_ops;
> -	mp2_ops->clear_intr = amd_sfh_clear_intr_v2,
> -	mp2_ops->init_intr = amd_sfh_irq_init_v2,
> +	mp2_ops->clear_intr = amd_sfh_clear_intr_v2;
> +	mp2_ops->init_intr = amd_sfh_irq_init_v2;
>  	mp2_ops->suspend = amd_sfh_suspend;
>  	mp2_ops->resume = amd_sfh_resume;
>  	mp2_ops->remove = amd_mp2_pci_remove;

Looks good to me.

Acked-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>

Thanks,
--
Basavaraj