When CONFIG_FBNIC=m, the following error occurs:

	ERROR: modpost: "priv_to_devlink" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
	ERROR: modpost: "page_pool_create" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
	ERROR: modpost: "devlink_info_serial_number_put" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
	ERROR: modpost: "page_pool_alloc_pages" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
	ERROR: modpost: "devlink_priv" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
	ERROR: modpost: "page_pool_put_unrefed_page" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
	ERROR: modpost: "devlink_unregister" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
	ERROR: modpost: "devlink_alloc_ns" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
	ERROR: modpost: "devlink_register" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
	ERROR: modpost: "devlink_free" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!

The driver now uses functions exported from a helper module
but fails to link when the helper is disabled, select them to fix them

Fixes: 546dd90be979 ("eth: fbnic: Add scaffolding for Meta's NIC driver")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
 drivers/net/ethernet/meta/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/meta/Kconfig b/drivers/net/ethernet/meta/Kconfig
index c002ede36402..85519690b837 100644
--- a/drivers/net/ethernet/meta/Kconfig
+++ b/drivers/net/ethernet/meta/Kconfig
@@ -23,6 +23,8 @@ config FBNIC
 	depends on !S390
 	depends on MAX_SKB_FRAGS < 22
 	depends on PCI_MSI
+	select NET_DEVLINK
+	select PAGE_POOL
 	select PHYLINK
 	help
 	  This driver supports Meta Platforms Host Network Interface.
-- 
2.34.1

On Mon, Sep 02, 2024 at 09:19:47PM +0800, Jinjie Ruan wrote:
> When CONFIG_FBNIC=m, the following error occurs:
> 
> 	ERROR: modpost: "priv_to_devlink" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
> 	ERROR: modpost: "page_pool_create" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
> 	ERROR: modpost: "devlink_info_serial_number_put" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
> 	ERROR: modpost: "page_pool_alloc_pages" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
> 	ERROR: modpost: "devlink_priv" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
> 	ERROR: modpost: "page_pool_put_unrefed_page" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
> 	ERROR: modpost: "devlink_unregister" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
> 	ERROR: modpost: "devlink_alloc_ns" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
> 	ERROR: modpost: "devlink_register" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
> 	ERROR: modpost: "devlink_free" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
> 
> The driver now uses functions exported from a helper module
> but fails to link when the helper is disabled, select them to fix them
> 
> Fixes: 546dd90be979 ("eth: fbnic: Add scaffolding for Meta's NIC driver")
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>

Thanks,

I believe a patch for this problem is already present upstream.

- 9a95b7a89dff ("eth: fbnic: select DEVLINK and PAGE_POOL")
  https://git.kernel.org/netdev/net-next/c/9a95b7a89dff

-- 
pw-bot: not-applicable

On 2024/9/3 3:06, Simon Horman wrote:
> On Mon, Sep 02, 2024 at 09:19:47PM +0800, Jinjie Ruan wrote:
>> When CONFIG_FBNIC=m, the following error occurs:
>>
>> 	ERROR: modpost: "priv_to_devlink" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
>> 	ERROR: modpost: "page_pool_create" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
>> 	ERROR: modpost: "devlink_info_serial_number_put" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
>> 	ERROR: modpost: "page_pool_alloc_pages" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
>> 	ERROR: modpost: "devlink_priv" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
>> 	ERROR: modpost: "page_pool_put_unrefed_page" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
>> 	ERROR: modpost: "devlink_unregister" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
>> 	ERROR: modpost: "devlink_alloc_ns" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
>> 	ERROR: modpost: "devlink_register" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
>> 	ERROR: modpost: "devlink_free" [drivers/net/ethernet/meta/fbnic/fbnic.ko] undefined!
>>
>> The driver now uses functions exported from a helper module
>> but fails to link when the helper is disabled, select them to fix them
>>
>> Fixes: 546dd90be979 ("eth: fbnic: Add scaffolding for Meta's NIC driver")
>> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> 
> Thanks,
> 
> I believe a patch for this problem is already present upstream.

Sorry, I compile the mainline kernel and find this problem, and not
notice it.

> 
> - 9a95b7a89dff ("eth: fbnic: select DEVLINK and PAGE_POOL")
>   https://git.kernel.org/netdev/net-next/c/9a95b7a89dff
>