gpio: pch: kerneldoc fixes for excess members

[PATCH v2] gpio: pch: kerneldoc fixes for excess members

Posted by Krzysztof Kozlowski 1 year, 5 months ago

Drop kerneldoc description of 'lock' to fix W=1 warning:

  drivers/gpio/gpio-pch.c:101: warning: Excess struct member 'lock' description in 'pch_gpio'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Changes in v2:
1. Rebase
---
 drivers/gpio/gpio-pch.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c
index ee37ecb615cb..63f25c72eac2 100644
--- a/drivers/gpio/gpio-pch.c
+++ b/drivers/gpio/gpio-pch.c
@@ -84,7 +84,6 @@ struct pch_gpio_reg_data {
  * @gpio:			Data for GPIO infrastructure.
  * @pch_gpio_reg:		Memory mapped Register data is saved here
  *				when suspend.
- * @lock:			Used for register access protection
  * @irq_base:		Save base of IRQ number for interrupt
  * @ioh:		IOH ID
  * @spinlock:		Used for register access protection
-- 
2.43.0

Re: [PATCH v2] gpio: pch: kerneldoc fixes for excess members

Posted by Bartosz Golaszewski 1 year, 5 months ago

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Mon, 02 Sep 2024 14:12:58 +0200, Krzysztof Kozlowski wrote:
> Drop kerneldoc description of 'lock' to fix W=1 warning:
> 
>   drivers/gpio/gpio-pch.c:101: warning: Excess struct member 'lock' description in 'pch_gpio'
> 
> 

Applied, thanks!

[1/1] gpio: pch: kerneldoc fixes for excess members
      commit: e1df5d0229c37265e4a84a32e71690c5089d2f5b

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Re: [PATCH v2] gpio: pch: kerneldoc fixes for excess members

Posted by Krzysztof Kozlowski 1 year, 5 months ago

On 02/09/2024 14:12, Krzysztof Kozlowski wrote:
> Drop kerneldoc description of 'lock' to fix W=1 warning:
> 
>   drivers/gpio/gpio-pch.c:101: warning: Excess struct member 'lock' description in 'pch_gpio'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Changes in v2:
> 1. Rebase

Eh, crap, forgot tag which now applies completely:

Reviewed-by: Andy Shevchenko <andy@kernel.org>

Best regards,
Krzysztof

Re: [PATCH v2] gpio: pch: kerneldoc fixes for excess members

Posted by Andy Shevchenko 1 year, 5 months ago

On Mon, Sep 02, 2024 at 02:13:56PM +0200, Krzysztof Kozlowski wrote:
> On 02/09/2024 14:12, Krzysztof Kozlowski wrote:
> > Drop kerneldoc description of 'lock' to fix W=1 warning:
> > 
> >   drivers/gpio/gpio-pch.c:101: warning: Excess struct member 'lock' description in 'pch_gpio'

...

> Eh, crap, forgot tag which now applies completely:
> 
> Reviewed-by: Andy Shevchenko <andy@kernel.org>

Yep, thank you!

-- 
With Best Regards,
Andy Shevchenko