[PATCH v4] binder: modify the comment for binder_proc_unlock

Ba Jing posted 1 patch 1 year, 3 months ago
There is a newer version of this series
drivers/android/binder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v4] binder: modify the comment for binder_proc_unlock
Posted by Ba Jing 1 year, 3 months ago
Modify the comment for binder_proc_unlock() to clearly indicate which spinlock it releases and to better match the acquire comment block in binder_proc_lock().

Notes:
v1: https://lore.kernel.org/all/20240830073743.2052-1-bajing@cmss.chinamobile.com/

v2: Reword commit log per suggestions from cmllamas@
https://lore.kernel.org/all/20240902013636.1739-1-bajing@cmss.chinamobile.com/

v3: Wrap commit message. Add version history.
https://lore.kernel.org/all/20240902025720.2334-1-bajing@cmss.chinamobile.com/

v4: Modify the commit information.

Signed-off-by: Ba Jing <bajing@cmss.chinamobile.com>
---
 drivers/android/binder.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index fc55b5d0e4f3..578861d57045 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -277,7 +277,7 @@ _binder_proc_lock(struct binder_proc *proc, int line)
 }
 
 /**
- * binder_proc_unlock() - Release spinlock for given binder_proc
+ * binder_proc_unlock() - Release outer lock for given binder_proc
  * @proc:                struct binder_proc to acquire
  *
  * Release lock acquired via binder_proc_lock()
-- 
2.33.0
Re: [PATCH v4] binder: modify the comment for binder_proc_unlock
Posted by Greg KH 1 year, 3 months ago
On Mon, Sep 02, 2024 at 11:37:54AM +0800, Ba Jing wrote:
> Modify the comment for binder_proc_unlock() to clearly indicate which spinlock it releases and to better match the acquire comment block in binder_proc_lock().
> 
> Notes:
> v1: https://lore.kernel.org/all/20240830073743.2052-1-bajing@cmss.chinamobile.com/
> 
> v2: Reword commit log per suggestions from cmllamas@
> https://lore.kernel.org/all/20240902013636.1739-1-bajing@cmss.chinamobile.com/
> 
> v3: Wrap commit message. Add version history.
> https://lore.kernel.org/all/20240902025720.2334-1-bajing@cmss.chinamobile.com/
> 
> v4: Modify the commit information.

Again, all of these "what changed in what version" needs to go below the
--- line.

Also, please wrap your changelog text at 72 columns, like your editor
asked you to :)

thanks,

greg k-h