[PATCH -next] genirq/timings: Use time_after_eq() macro

Jinjie Ruan posted 1 patch 1 year, 3 months ago
kernel/irq/timings.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH -next] genirq/timings: Use time_after_eq() macro
Posted by Jinjie Ruan 1 year, 3 months ago
Use time_after_eq() macro instead of directly handling it.

Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
 kernel/irq/timings.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/irq/timings.c b/kernel/irq/timings.c
index 69f103b4c7a6..a96c0f1346fd 100644
--- a/kernel/irq/timings.c
+++ b/kernel/irq/timings.c
@@ -383,7 +383,7 @@ static u64 __irq_timings_next_event(struct irqt_stat *irqs, int irq, u64 now)
 {
 	int index, i, period_max, count, start, min = INT_MAX;
 
-	if ((now - irqs->last_ts) >= NSEC_PER_SEC) {
+	if (time_after_eq(now, irqs->last_ts + NSEC_PER_SEC)) {
 		irqs->count = irqs->last_ts = 0;
 		return U64_MAX;
 	}
-- 
2.34.1
Re: [PATCH -next] genirq/timings: Use time_after_eq() macro
Posted by Thomas Gleixner 1 year, 3 months ago
On Mon, Sep 02 2024 at 10:57, Jinjie Ruan wrote:
> @@ -383,7 +383,7 @@ static u64 __irq_timings_next_event(struct irqt_stat *irqs, int irq, u64 now)
>  {
>  	int index, i, period_max, count, start, min = INT_MAX;
>  
> -	if ((now - irqs->last_ts) >= NSEC_PER_SEC) {
> +	if (time_after_eq(now, irqs->last_ts + NSEC_PER_SEC)) {

time_after_eq() is meant for handling jiffies and not for arbitraty time
stamps which have nothing to do with jiffies at all

Thanks,

        tglx