[PATCH] nvmem: sunplus-ocotp: Use devm_platform_ioremap_resource_byname() helper function

Zhang Zekun posted 1 patch 1 year, 3 months ago
drivers/nvmem/sunplus-ocotp.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
[PATCH] nvmem: sunplus-ocotp: Use devm_platform_ioremap_resource_byname() helper function
Posted by Zhang Zekun 1 year, 3 months ago
platform_get_resource_byname() and devm_ioremap_resource() can be
replaced by devm_platform_ioremap_resource_byname(), which can
simplify the code logic a bit, No functional change here.

Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com>
---
 drivers/nvmem/sunplus-ocotp.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/nvmem/sunplus-ocotp.c b/drivers/nvmem/sunplus-ocotp.c
index 38f5d9df39cd..30d55b111a64 100644
--- a/drivers/nvmem/sunplus-ocotp.c
+++ b/drivers/nvmem/sunplus-ocotp.c
@@ -159,7 +159,6 @@ static int sp_ocotp_probe(struct platform_device *pdev)
 	struct device *dev = &pdev->dev;
 	struct nvmem_device *nvmem;
 	struct sp_ocotp_priv *otp;
-	struct resource *res;
 	int ret;
 
 	otp = devm_kzalloc(dev, sizeof(*otp), GFP_KERNEL);
@@ -168,13 +167,11 @@ static int sp_ocotp_probe(struct platform_device *pdev)
 
 	otp->dev = dev;
 
-	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "hb_gpio");
-	otp->base[HB_GPIO] = devm_ioremap_resource(dev, res);
+	otp->base[HB_GPIO] = devm_platform_ioremap_resource_byname(pdev, "hb_gpio");
 	if (IS_ERR(otp->base[HB_GPIO]))
 		return PTR_ERR(otp->base[HB_GPIO]);
 
-	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "otprx");
-	otp->base[OTPRX] = devm_ioremap_resource(dev, res);
+	otp->base[OTPRX] = devm_platform_ioremap_resource_byname(pdev, "otprx");
 	if (IS_ERR(otp->base[OTPRX]))
 		return PTR_ERR(otp->base[OTPRX]);
 
-- 
2.17.1
Re: [PATCH] nvmem: sunplus-ocotp: Use devm_platform_ioremap_resource_byname() helper function
Posted by Srinivas Kandagatla 1 year, 3 months ago
On Mon, 02 Sep 2024 09:50:51 +0800, Zhang Zekun wrote:
> platform_get_resource_byname() and devm_ioremap_resource() can be
> replaced by devm_platform_ioremap_resource_byname(), which can
> simplify the code logic a bit, No functional change here.
> 
> 

Applied, thanks!

[1/1] nvmem: sunplus-ocotp: Use devm_platform_ioremap_resource_byname() helper function
      commit: f940496293787ddfa481f2dc67fed60148212d83

Best regards,
-- 
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>