[PATCH] Fix sysfs rebalance duration waited formatting

Feiko Nanninga posted 1 patch 1 year, 3 months ago
fs/bcachefs/util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] Fix sysfs rebalance duration waited formatting
Posted by Feiko Nanninga 1 year, 3 months ago
cat /sys/fs/bcachefs/*/internal/rebalance_status
waiting
  io wait duration:  13.5 GiB
  io wait remaining: 627 MiB
  duration waited:   1392 m

duration waited was increasing at a rate of about 14 times the expected
rate.

div_u64 takes a u32 divisor, but u->nsecs (from time_units[]) can be
bigger than u32.

Signed-off-by: Feiko Nanninga <feiko.nanninga@fnanninga.de>
---
 fs/bcachefs/util.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/bcachefs/util.c b/fs/bcachefs/util.c
index 1b8554460af4..a6c9c96955f1 100644
--- a/fs/bcachefs/util.c
+++ b/fs/bcachefs/util.c
@@ -360,7 +360,7 @@ void bch2_pr_time_units(struct printbuf *out, u64 ns)
 {
 	const struct time_unit *u = bch2_pick_time_units(ns);
 
-	prt_printf(out, "%llu %s", div_u64(ns, u->nsecs), u->name);
+	prt_printf(out, "%llu %s", div64_u64(ns, u->nsecs), u->name);
 }
 
 static void bch2_pr_time_units_aligned(struct printbuf *out, u64 ns)
-- 
2.45.2
Re: [PATCH] Fix sysfs rebalance duration waited formatting
Posted by Kent Overstreet 1 year, 3 months ago
On Sun, Sep 01, 2024 at 07:08:05PM GMT, Feiko Nanninga wrote:
> cat /sys/fs/bcachefs/*/internal/rebalance_status
> waiting
>   io wait duration:  13.5 GiB
>   io wait remaining: 627 MiB
>   duration waited:   1392 m
> 
> duration waited was increasing at a rate of about 14 times the expected
> rate.
> 
> div_u64 takes a u32 divisor, but u->nsecs (from time_units[]) can be
> bigger than u32.
> 
> Signed-off-by: Feiko Nanninga <feiko.nanninga@fnanninga.de>

Thanks, applied