staging: rtl8192e: Rename variable eRFPath

[PATCH] staging: rtl8192e: Rename variable eRFPath

Posted by Riyan Dhiman 1 year, 5 months ago

Rename variable eRFPath to erf_path to fix checkpatch
warning.

Issue reported in checkpatch:
-CHECK: Avoid CamelCase: <eRFPath>

Signed-off-by: Riyan Dhiman <riyandhiman14@gmail.com>
---
 .../staging/rtl8192e/rtl8192e/r8190P_rtl8256.c   | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c b/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
index 7061f1cf4d3a..256c19739ad1 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
@@ -12,7 +12,7 @@
 void rtl92e_set_bandwidth(struct net_device *dev,
 			  enum ht_channel_width bandwidth)
 {
-	u8	eRFPath;
+	u8	erf_path;
 	struct r8192_priv *priv = rtllib_priv(dev);
 
 	if (priv->card_8192_version != VERSION_8190_BD &&
@@ -21,22 +21,22 @@ void rtl92e_set_bandwidth(struct net_device *dev,
 		return;
 	}
 
-	for (eRFPath = 0; eRFPath < priv->num_total_rf_path; eRFPath++) {
+	for (erf_path = 0; erf_path < priv->num_total_rf_path; erf_path++) {
 		switch (bandwidth) {
 		case HT_CHANNEL_WIDTH_20:
-			rtl92e_set_rf_reg(dev, (enum rf90_radio_path)eRFPath,
+			rtl92e_set_rf_reg(dev, (enum rf90_radio_path)erf_path,
 					  0x0b, bMask12Bits, 0x100);
-			rtl92e_set_rf_reg(dev, (enum rf90_radio_path)eRFPath,
+			rtl92e_set_rf_reg(dev, (enum rf90_radio_path)erf_path,
 					  0x2c, bMask12Bits, 0x3d7);
-			rtl92e_set_rf_reg(dev, (enum rf90_radio_path)eRFPath,
+			rtl92e_set_rf_reg(dev, (enum rf90_radio_path)erf_path,
 					  0x0e, bMask12Bits, 0x021);
 			break;
 		case HT_CHANNEL_WIDTH_20_40:
-			rtl92e_set_rf_reg(dev, (enum rf90_radio_path)eRFPath,
+			rtl92e_set_rf_reg(dev, (enum rf90_radio_path)erf_path,
 					  0x0b, bMask12Bits, 0x300);
-			rtl92e_set_rf_reg(dev, (enum rf90_radio_path)eRFPath,
+			rtl92e_set_rf_reg(dev, (enum rf90_radio_path)erf_path,
 					  0x2c, bMask12Bits, 0x3ff);
-			rtl92e_set_rf_reg(dev, (enum rf90_radio_path)eRFPath,
+			rtl92e_set_rf_reg(dev, (enum rf90_radio_path)erf_path,
 					  0x0e, bMask12Bits, 0x0e1);
 			break;
 		default:
-- 
2.46.0

Re: [PATCH] staging: rtl8192e: Rename variable eRFPath

Posted by Dan Carpenter 1 year, 5 months ago

On Sat, Aug 31, 2024 at 08:29:32PM +0530, Riyan Dhiman wrote:
> Rename variable eRFPath to erf_path to fix checkpatch
> warning.
> 
> Issue reported in checkpatch:
> -CHECK: Avoid CamelCase: <eRFPath>
> 
> Signed-off-by: Riyan Dhiman <riyandhiman14@gmail.com>
> ---
>  .../staging/rtl8192e/rtl8192e/r8190P_rtl8256.c   | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c b/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
> index 7061f1cf4d3a..256c19739ad1 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c
> @@ -12,7 +12,7 @@
>  void rtl92e_set_bandwidth(struct net_device *dev,
>  			  enum ht_channel_width bandwidth)
>  {
> -	u8	eRFPath;
> +	u8	erf_path;

e stands for enum.  We don't like this kind of name.  Just call it rf_path.

regards,
dan carpenter