[PATCH 0/2] Added debugfs node initialization and null pointer detection.

Yibin Ding posted 2 patches 1 year, 3 months ago
Only 0 patches received!
There is a newer version of this series
drivers/interconnect/debugfs-client.c | 10 ++++++++--
fs/debugfs/file.c                     |  4 ++++
2 files changed, 12 insertions(+), 2 deletions(-)
[PATCH 0/2] Added debugfs node initialization and null pointer detection.
Posted by Yibin Ding 1 year, 3 months ago
From: Yibin Ding <Yibin.ding@unisoc.com>

The two debugfs nodes (/sys/kernel/debug/interconnect/test_client/dst_node,
src_node) do not initialize the character pointers before creation. For
such uninitialized nodes, direct access will cause a crash due to accessing
a null pointer.
For example, directly execute the following command after booting:
    cat /sys/kernel/debug/interconnect/test_client/dst_node.

Therefore, for the problem nodes, it is necessary to add initialization
operations and null pointer detection when accessing.

Yibin Ding (2):
  interconnect: Add character pointer initialization
  debugfs: Fix crash problem caused by accessing uninitialized nodes

 drivers/interconnect/debugfs-client.c | 10 ++++++++--
 fs/debugfs/file.c                     |  4 ++++
 2 files changed, 12 insertions(+), 2 deletions(-)

-- 
2.25.1
Re: [PATCH 0/2] Added debugfs node initialization and null pointer detection.
Posted by Greg KH 1 year, 3 months ago
On Fri, Aug 30, 2024 at 06:21:53PM +0800, Yibin Ding wrote:
> From: Yibin Ding <Yibin.ding@unisoc.com>
> 
> The two debugfs nodes (/sys/kernel/debug/interconnect/test_client/dst_node,
> src_node) do not initialize the character pointers before creation. For
> such uninitialized nodes, direct access will cause a crash due to accessing
> a null pointer.
> For example, directly execute the following command after booting:
>     cat /sys/kernel/debug/interconnect/test_client/dst_node.
> 
> Therefore, for the problem nodes, it is necessary to add initialization
> operations and null pointer detection when accessing.
> 
> Yibin Ding (2):
>   interconnect: Add character pointer initialization
>   debugfs: Fix crash problem caused by accessing uninitialized nodes
> 
>  drivers/interconnect/debugfs-client.c | 10 ++++++++--
>  fs/debugfs/file.c                     |  4 ++++
>  2 files changed, 12 insertions(+), 2 deletions(-)
> 
> -- 
> 2.25.1
> 

This series is not properly threaded for some reason.  Can you resend
using a tool (like git send-email or something else) that preserves it
so that our tools can correctly pick them up?

thanks,

greg k-h