[PATCH net-next 3/3] cxgb: Remove unused declarations

Yue Haibing posted 3 patches 1 year, 5 months ago
There is a newer version of this series
[PATCH net-next 3/3] cxgb: Remove unused declarations
Posted by Yue Haibing 1 year, 5 months ago
These were never implenmented since introduction in commit 4d22de3e6cc4
("Add support for the latest 1G/10G Chelsio adapter, T3.").

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 drivers/net/ethernet/chelsio/cxgb/common.h | 2 --
 drivers/net/ethernet/chelsio/cxgb/tp.h     | 2 --
 2 files changed, 4 deletions(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb/common.h b/drivers/net/ethernet/chelsio/cxgb/common.h
index e56eff701395..304bb282ab03 100644
--- a/drivers/net/ethernet/chelsio/cxgb/common.h
+++ b/drivers/net/ethernet/chelsio/cxgb/common.h
@@ -329,8 +329,6 @@ irqreturn_t t1_slow_intr_handler(adapter_t *adapter);
 
 int t1_link_start(struct cphy *phy, struct cmac *mac, struct link_config *lc);
 const struct board_info *t1_get_board_info(unsigned int board_id);
-const struct board_info *t1_get_board_info_from_ids(unsigned int devid,
-						    unsigned short ssid);
 int t1_seeprom_read(adapter_t *adapter, u32 addr, __le32 *data);
 int t1_get_board_rev(adapter_t *adapter, const struct board_info *bi,
 		     struct adapter_params *p);
diff --git a/drivers/net/ethernet/chelsio/cxgb/tp.h b/drivers/net/ethernet/chelsio/cxgb/tp.h
index ba15675d56df..64f93dcc676b 100644
--- a/drivers/net/ethernet/chelsio/cxgb/tp.h
+++ b/drivers/net/ethernet/chelsio/cxgb/tp.h
@@ -65,9 +65,7 @@ void t1_tp_intr_enable(struct petp *tp);
 void t1_tp_intr_clear(struct petp *tp);
 int t1_tp_intr_handler(struct petp *tp);
 
-void t1_tp_get_mib_statistics(adapter_t *adap, struct tp_mib_statistics *tps);
 void t1_tp_set_tcp_checksum_offload(struct petp *tp, int enable);
 void t1_tp_set_ip_checksum_offload(struct petp *tp, int enable);
-int t1_tp_set_coalescing_size(struct petp *tp, unsigned int size);
 int t1_tp_reset(struct petp *tp, struct tp_params *p, unsigned int tp_clk);
 #endif
-- 
2.34.1
Re: [PATCH net-next 3/3] cxgb: Remove unused declarations
Posted by Simon Horman 1 year, 5 months ago
On Thu, Aug 29, 2024 at 08:37:07PM +0800, Yue Haibing wrote:
> These were never implenmented since introduction in commit 4d22de3e6cc4
> ("Add support for the latest 1G/10G Chelsio adapter, T3.").
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Hi,

I agree that these were never implemented, but I think the at the
correct citation is:

commit 8199d3a79c22 ("[PATCH] A new 10GB Ethernet Driver by Chelsio Communications")

...
Re: [PATCH net-next 3/3] cxgb: Remove unused declarations
Posted by Yue Haibing 1 year, 5 months ago
On 2024/8/30 15:36, Simon Horman wrote:
> On Thu, Aug 29, 2024 at 08:37:07PM +0800, Yue Haibing wrote:
>> These were never implenmented since introduction in commit 4d22de3e6cc4
>> ("Add support for the latest 1G/10G Chelsio adapter, T3.").
>>
>> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> 
> Hi,
> 
> I agree that these were never implemented, but I think the at the
> correct citation is:
> 
> commit 8199d3a79c22 ("[PATCH] A new 10GB Ethernet Driver by Chelsio Communications")

Indeed, I missed this one, thanks!

> 
> ...
> .