[v4] staging: rtl8192e: Fix parenthesis alignment in r8192E_dev.c 325

[PATCH v4] staging: rtl8192e: Fix parenthesis alignment in r8192E_dev.c 325

Posted by Nilo Alexandre 1 year, 3 months ago

Remove linebreak to improve readability

CHECK: Alignment should match open parenthesis

Signed-off-by: Nilo Alexandre <n1lux.comp@gmail.com>
---
v4: Remove linebreak to improve readability
v3: Fix typo in commit message.
v2: Using tabs instead of spaces.
---
 drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index b25e83743956d..a80efe6c7c209 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -321,8 +321,7 @@ static void _rtl92e_read_eeprom_info(struct net_device *dev)
 
 		if (priv->epromtype == EEPROM_93C46) {
 			if (!priv->autoload_fail_flag) {
-				usValue = rtl92e_eeprom_read(dev,
-					  EEPROM_TxPwDiff_CrystalCap >> 1);
+				usValue = rtl92e_eeprom_read(dev, EEPROM_TxPwDiff_CrystalCap >> 1);
 				priv->eeprom_ant_pwr_diff = usValue & 0x0fff;
 				priv->eeprom_crystal_cap = (usValue & 0xf000)
 							 >> 12;
-- 
2.46.0

Re: [PATCH v4] staging: rtl8192e: Fix parenthesis alignment in r8192E_dev.c 325

Posted by Greg KH 1 year, 3 months ago

On Tue, Aug 27, 2024 at 10:18:42PM -0300, Nilo Alexandre wrote:
> Remove linebreak to improve readability
> 
> CHECK: Alignment should match open parenthesis
> 
> Signed-off-by: Nilo Alexandre <n1lux.comp@gmail.com>

What is the "325" in the subject line for?

Re: [PATCH v4] staging: rtl8192e: Fix parenthesis alignment in r8192E_dev.c 325

Posted by Philipp Hortmann 1 year, 3 months ago

On 8/28/24 03:18, Nilo Alexandre wrote:
> Remove linebreak to improve readability
> 
Hi Nilo,

please end the above sentences with a ".".


> CHECK: Alignment should match open parenthesis
Why do we need the above line?

Thanks for your support.

Bye Philipp
> 
> Signed-off-by: Nilo Alexandre <n1lux.comp@gmail.com>
> ---
> v4: Remove linebreak to improve readability
> v3: Fix typo in commit message.
> v2: Using tabs instead of spaces.
> ---
>   drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> index b25e83743956d..a80efe6c7c209 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> @@ -321,8 +321,7 @@ static void _rtl92e_read_eeprom_info(struct net_device *dev)
>   
>   		if (priv->epromtype == EEPROM_93C46) {
>   			if (!priv->autoload_fail_flag) {
> -				usValue = rtl92e_eeprom_read(dev,
> -					  EEPROM_TxPwDiff_CrystalCap >> 1);
> +				usValue = rtl92e_eeprom_read(dev, EEPROM_TxPwDiff_CrystalCap >> 1);
>   				priv->eeprom_ant_pwr_diff = usValue & 0x0fff;
>   				priv->eeprom_crystal_cap = (usValue & 0xf000)
>   							 >> 12;