[PATCH 5/5 next] net: vertexcom: mse102x: Use ETH_ZLEN

Stefan Wahren posted 5 patches 1 year, 3 months ago
[PATCH 5/5 next] net: vertexcom: mse102x: Use ETH_ZLEN
Posted by Stefan Wahren 1 year, 3 months ago
There is already a define for minimum Ethernet frame length without FCS.
So used this instead of the magic number.

Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
---
 drivers/net/ethernet/vertexcom/mse102x.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/vertexcom/mse102x.c b/drivers/net/ethernet/vertexcom/mse102x.c
index 8a72d8699b84..a04d4073def9 100644
--- a/drivers/net/ethernet/vertexcom/mse102x.c
+++ b/drivers/net/ethernet/vertexcom/mse102x.c
@@ -377,8 +377,8 @@ static int mse102x_tx_pkt_spi(struct mse102x_net *mse, struct sk_buff *txb,
 	int ret;
 	bool first = true;

-	if (txb->len < 60)
-		pad = 60 - txb->len;
+	if (txb->len < ETH_ZLEN)
+		pad = ETH_ZLEN - txb->len;

 	while (1) {
 		mse102x_tx_cmd_spi(mse, CMD_RTS | (txb->len + pad));
--
2.34.1
Re: [PATCH 5/5 next] net: vertexcom: mse102x: Use ETH_ZLEN
Posted by Simon Horman 1 year, 3 months ago
On Tue, Aug 27, 2024 at 09:10:00PM +0200, Stefan Wahren wrote:
> There is already a define for minimum Ethernet frame length without FCS.
> So used this instead of the magic number.
> 
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>

Reviewed-by: Simon Horman <horms@kernel.org>