[PATCH 3/5 next] net: vertexcom: mse102x: Fix random MAC address log

Stefan Wahren posted 5 patches 1 year, 3 months ago
[PATCH 3/5 next] net: vertexcom: mse102x: Fix random MAC address log
Posted by Stefan Wahren 1 year, 3 months ago
At the time of MAC address assignment the netdev is not registered yet,
so netdev log functions won't work as expected. While we are at this
downgrade the log level to a warning, because a random MAC address is
not a real error.

Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
---
 drivers/net/ethernet/vertexcom/mse102x.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/vertexcom/mse102x.c b/drivers/net/ethernet/vertexcom/mse102x.c
index 336435fe8241..4ce027f8e376 100644
--- a/drivers/net/ethernet/vertexcom/mse102x.c
+++ b/drivers/net/ethernet/vertexcom/mse102x.c
@@ -485,8 +485,8 @@ static void mse102x_init_mac(struct mse102x_net *mse, struct device_node *np)

 	if (ret) {
 		eth_hw_addr_random(ndev);
-		netdev_err(ndev, "Using random MAC address: %pM\n",
-			   ndev->dev_addr);
+		dev_warn(ndev->dev.parent, "Using random MAC address: %pM\n",
+			 ndev->dev_addr);
 	}
 }

--
2.34.1
Re: [PATCH 3/5 next] net: vertexcom: mse102x: Fix random MAC address log
Posted by Simon Horman 1 year, 3 months ago
On Tue, Aug 27, 2024 at 09:09:58PM +0200, Stefan Wahren wrote:
> At the time of MAC address assignment the netdev is not registered yet,
> so netdev log functions won't work as expected. While we are at this
> downgrade the log level to a warning, because a random MAC address is
> not a real error.
> 
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>

Reviewed-by: Simon Horman <horms@kernel.org>