1. Patchew
  2. linux
  3. [PATCH 0/3] drm/bridge: microchip-lvds: Cleanups
  4. View patch

[PATCH 2/3] drm/bridge: microchip-lvds: Drop unused headers

Claudiu Beznea posted 3 patches 1 year, 3 months ago
[PATCH 2/3] drm/bridge: microchip-lvds: Drop unused headers
Posted by Claudiu Beznea 1 year, 3 months ago 
Drop unused headers. With this code becomes simpler.

Signed-off-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>
---
 drivers/gpu/drm/bridge/microchip-lvds.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/bridge/microchip-lvds.c b/drivers/gpu/drm/bridge/microchip-lvds.c
index 027292ab0197..f04831106eea 100644
--- a/drivers/gpu/drm/bridge/microchip-lvds.c
+++ b/drivers/gpu/drm/bridge/microchip-lvds.c
@@ -8,25 +8,16 @@
  */
 
 #include <linux/clk.h>
-#include <linux/component.h>
 #include <linux/delay.h>
 #include <linux/jiffies.h>
-#include <linux/mfd/syscon.h>
+#include <linux/of.h>
 #include <linux/of_graph.h>
-#include <linux/pinctrl/devinfo.h>
-#include <linux/phy/phy.h>
 #include <linux/platform_device.h>
 #include <linux/pm_runtime.h>
-#include <linux/regmap.h>
-#include <linux/reset.h>
 
-#include <drm/drm_atomic_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_of.h>
 #include <drm/drm_panel.h>
-#include <drm/drm_print.h>
-#include <drm/drm_probe_helper.h>
-#include <drm/drm_simple_kms_helper.h>
 
 #define LVDS_POLL_TIMEOUT_MS 1000
 
-- 
2.39.2
Re: [PATCH 2/3] drm/bridge: microchip-lvds: Drop unused headers
Posted by kernel test robot 1 year, 3 months ago 
Hi Claudiu,

kernel test robot noticed the following build errors:

[auto build test ERROR on drm-misc/drm-misc-next]
[also build test ERROR on linus/master v6.11-rc5 next-20240830]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Claudiu-Beznea/drm-bridge-microchip-lvds-Revert-clk_prepare_enable-in-case-of-failure/20240828-001456
base:   git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link:    https://lore.kernel.org/r/20240827161223.4152195-3-claudiu.beznea%40tuxon.dev
patch subject: [PATCH 2/3] drm/bridge: microchip-lvds: Drop unused headers
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20240901/202409011412.DQVmnHIW-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240901/202409011412.DQVmnHIW-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409011412.DQVmnHIW-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/bridge/microchip-lvds.c:62:9: error: call to undeclared function 'readl_relaxed'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
      62 |         return readl_relaxed(lvds->regs + offset);
         |                ^
>> drivers/gpu/drm/bridge/microchip-lvds.c:67:2: error: call to undeclared function 'writel_relaxed'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
      67 |         writel_relaxed(val, lvds->regs + offset);
         |         ^
   2 errors generated.


vim +/readl_relaxed +62 drivers/gpu/drm/bridge/microchip-lvds.c

179b0769fc5fc19 Dharma Balasubiramani 2024-04-21  59  
179b0769fc5fc19 Dharma Balasubiramani 2024-04-21  60  static inline u32 lvds_readl(struct mchp_lvds *lvds, u32 offset)
179b0769fc5fc19 Dharma Balasubiramani 2024-04-21  61  {
179b0769fc5fc19 Dharma Balasubiramani 2024-04-21 @62  	return readl_relaxed(lvds->regs + offset);
179b0769fc5fc19 Dharma Balasubiramani 2024-04-21  63  }
179b0769fc5fc19 Dharma Balasubiramani 2024-04-21  64  
179b0769fc5fc19 Dharma Balasubiramani 2024-04-21  65  static inline void lvds_writel(struct mchp_lvds *lvds, u32 offset, u32 val)
179b0769fc5fc19 Dharma Balasubiramani 2024-04-21  66  {
179b0769fc5fc19 Dharma Balasubiramani 2024-04-21 @67  	writel_relaxed(val, lvds->regs + offset);
179b0769fc5fc19 Dharma Balasubiramani 2024-04-21  68  }
179b0769fc5fc19 Dharma Balasubiramani 2024-04-21  69  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Re: [PATCH 2/3] drm/bridge: microchip-lvds: Drop unused headers
Posted by kernel test robot 1 year, 3 months ago 
Hi Claudiu,

kernel test robot noticed the following build errors:

[auto build test ERROR on drm-misc/drm-misc-next]
[also build test ERROR on linus/master v6.11-rc5 next-20240830]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Claudiu-Beznea/drm-bridge-microchip-lvds-Revert-clk_prepare_enable-in-case-of-failure/20240828-001456
base:   git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link:    https://lore.kernel.org/r/20240827161223.4152195-3-claudiu.beznea%40tuxon.dev
patch subject: [PATCH 2/3] drm/bridge: microchip-lvds: Drop unused headers
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20240831/202408311600.HvIve8JU-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240831/202408311600.HvIve8JU-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408311600.HvIve8JU-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/gpu/drm/bridge/microchip-lvds.c: In function 'lvds_readl':
>> drivers/gpu/drm/bridge/microchip-lvds.c:62:16: error: implicit declaration of function 'readl_relaxed' [-Werror=implicit-function-declaration]
      62 |         return readl_relaxed(lvds->regs + offset);
         |                ^~~~~~~~~~~~~
   drivers/gpu/drm/bridge/microchip-lvds.c: In function 'lvds_writel':
>> drivers/gpu/drm/bridge/microchip-lvds.c:67:9: error: implicit declaration of function 'writel_relaxed' [-Werror=implicit-function-declaration]
      67 |         writel_relaxed(val, lvds->regs + offset);
         |         ^~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/readl_relaxed +62 drivers/gpu/drm/bridge/microchip-lvds.c

179b0769fc5fc1 Dharma Balasubiramani 2024-04-21  59  
179b0769fc5fc1 Dharma Balasubiramani 2024-04-21  60  static inline u32 lvds_readl(struct mchp_lvds *lvds, u32 offset)
179b0769fc5fc1 Dharma Balasubiramani 2024-04-21  61  {
179b0769fc5fc1 Dharma Balasubiramani 2024-04-21 @62  	return readl_relaxed(lvds->regs + offset);
179b0769fc5fc1 Dharma Balasubiramani 2024-04-21  63  }
179b0769fc5fc1 Dharma Balasubiramani 2024-04-21  64  
179b0769fc5fc1 Dharma Balasubiramani 2024-04-21  65  static inline void lvds_writel(struct mchp_lvds *lvds, u32 offset, u32 val)
179b0769fc5fc1 Dharma Balasubiramani 2024-04-21  66  {
179b0769fc5fc1 Dharma Balasubiramani 2024-04-21 @67  	writel_relaxed(val, lvds->regs + offset);
179b0769fc5fc1 Dharma Balasubiramani 2024-04-21  68  }
179b0769fc5fc1 Dharma Balasubiramani 2024-04-21  69  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.