[PATCH net-next RESEND 3/3] net: hisilicon: hns_mdio: fix OF node leak in probe()

Krzysztof Kozlowski posted 3 patches 1 year, 3 months ago
[PATCH net-next RESEND 3/3] net: hisilicon: hns_mdio: fix OF node leak in probe()
Posted by Krzysztof Kozlowski 1 year, 3 months ago
Driver is leaking OF node reference from
of_parse_phandle_with_fixed_args() in probe().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/net/ethernet/hisilicon/hns_mdio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/hisilicon/hns_mdio.c b/drivers/net/ethernet/hisilicon/hns_mdio.c
index ed73707176c1..8a047145f0c5 100644
--- a/drivers/net/ethernet/hisilicon/hns_mdio.c
+++ b/drivers/net/ethernet/hisilicon/hns_mdio.c
@@ -575,6 +575,7 @@ static int hns_mdio_probe(struct platform_device *pdev)
 						MDIO_SC_RESET_ST;
 				}
 			}
+			of_node_put(reg_args.np);
 		} else {
 			dev_warn(&pdev->dev, "find syscon ret = %#x\n", ret);
 			mdio_dev->subctrl_vbase = NULL;
-- 
2.43.0
Re: [PATCH net-next RESEND 3/3] net: hisilicon: hns_mdio: fix OF node leak in probe()
Posted by Simon Horman 1 year, 3 months ago
On Tue, Aug 27, 2024 at 04:44:21PM +0200, Krzysztof Kozlowski wrote:
> Driver is leaking OF node reference from
> of_parse_phandle_with_fixed_args() in probe().
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Simon Horman <horms@kernel.org>