Add coresight components for x1e80100. This change includes CTI,
dummy sink, dynamic Funnel, Replicator, STM, TPDM, TPDA and TMC ETF.

Change in V1:
Check the dtb with dtbs_check W=1, and fix the warnings for
the change.

Jie Gan (1):
  arm64: dts: qcom: Add coresight nodes for x1e80100

 arch/arm64/boot/dts/qcom/x1e80100.dtsi | 1514 ++++++++++++++++++++++++
 1 file changed, 1514 insertions(+)

-- 
2.34.1

On 27.08.2024 9:27 AM, Jie Gan wrote:
> Add coresight components for x1e80100. This change includes CTI,
> dummy sink, dynamic Funnel, Replicator, STM, TPDM, TPDA and TMC ETF.
> 
> Change in V1:
> Check the dtb with dtbs_check W=1, and fix the warnings for
> the change.
> 

Applying this series and enabling CORESIGHT=m (along with all the options
in menuconfig) breaks booting on my X1E Surface Laptop 7

Konrad

On Mon, Sep 02, 2024 at 05:27:32PM +0200, Konrad Dybcio wrote:
> On 27.08.2024 9:27 AM, Jie Gan wrote:
> > Add coresight components for x1e80100. This change includes CTI,
> > dummy sink, dynamic Funnel, Replicator, STM, TPDM, TPDA and TMC ETF.
> > 
> > Change in V1:
> > Check the dtb with dtbs_check W=1, and fix the warnings for
> > the change.
> > 
> 
> Applying this series and enabling CORESIGHT=m (along with all the options
> in menuconfig) breaks booting on my X1E Surface Laptop 7
> 
> Konrad

Did not observe any booting issues with our devices. Any relevant log to share?
This patch also tested by my colleague.

Can you successfully boot without the patch?

Thanks,
Jie

On 3.09.2024 3:30 AM, JieGan wrote:
> On Mon, Sep 02, 2024 at 05:27:32PM +0200, Konrad Dybcio wrote:
>> On 27.08.2024 9:27 AM, Jie Gan wrote:
>>> Add coresight components for x1e80100. This change includes CTI,
>>> dummy sink, dynamic Funnel, Replicator, STM, TPDM, TPDA and TMC ETF.
>>>
>>> Change in V1:
>>> Check the dtb with dtbs_check W=1, and fix the warnings for
>>> the change.
>>>
>>
>> Applying this series and enabling CORESIGHT=m (along with all the options
>> in menuconfig) breaks booting on my X1E Surface Laptop 7
>>
>> Konrad
> 
> Did not observe any booting issues with our devices. Any relevant log to share?
> This patch also tested by my colleague.

Sorry, it crashes too early and my device doesn't seem to have an
easily accessible serial port. Does any of the functionality
described here require an unsecured device?

What tag did you test this patch against?

> 
> Can you successfully boot without the patch?

Yes.

Konrad

On Wed, Sep 04, 2024 at 12:24:19PM +0200, Konrad Dybcio wrote:
> On 3.09.2024 3:30 AM, JieGan wrote:
> > On Mon, Sep 02, 2024 at 05:27:32PM +0200, Konrad Dybcio wrote:
> >> On 27.08.2024 9:27 AM, Jie Gan wrote:
> >>> Add coresight components for x1e80100. This change includes CTI,
> >>> dummy sink, dynamic Funnel, Replicator, STM, TPDM, TPDA and TMC ETF.
> >>>
> >>> Change in V1:
> >>> Check the dtb with dtbs_check W=1, and fix the warnings for
> >>> the change.
> >>>
> >>
> >> Applying this series and enabling CORESIGHT=m (along with all the options
> >> in menuconfig) breaks booting on my X1E Surface Laptop 7
> >>
> >> Konrad
> > 
> > Did not observe any booting issues with our devices. Any relevant log to share?
> > This patch also tested by my colleague.
> 
> Sorry, it crashes too early and my device doesn't seem to have an
> easily accessible serial port. Does any of the functionality
> described here require an unsecured device?
> 
I just checked the devices we used to test, they are all unsecured devices.
I also checked the dts, there are two components(known issue internally)
will fail the booting of the secure device.

I will disable those two components in next version. You can test it
with next patch.

Thanks for testing.

> What tag did you test this patch against?

next-20240820

> 
> > 
> > Can you successfully boot without the patch?
> 
> Yes.
> 
> Konrad

Thanks,
Jie

On 03/09/2024 03:30, JieGan wrote:
> On Mon, Sep 02, 2024 at 05:27:32PM +0200, Konrad Dybcio wrote:
>> On 27.08.2024 9:27 AM, Jie Gan wrote:
>>> Add coresight components for x1e80100. This change includes CTI,
>>> dummy sink, dynamic Funnel, Replicator, STM, TPDM, TPDA and TMC ETF.
>>>
>>> Change in V1:
>>> Check the dtb with dtbs_check W=1, and fix the warnings for
>>> the change.
>>>
>>
>> Applying this series and enabling CORESIGHT=m (along with all the options
>> in menuconfig) breaks booting on my X1E Surface Laptop 7
>>
>> Konrad
> 
> Did not observe any booting issues with our devices. Any relevant log to share?
> This patch also tested by my colleague.
> 
> Can you successfully boot without the patch?

I think that's the definition of "breaks booting"...

Best regards,
Krzysztof

On Wed, Sep 04, 2024 at 12:08:51PM +0200, Krzysztof Kozlowski wrote:
> On 03/09/2024 03:30, JieGan wrote:
> > On Mon, Sep 02, 2024 at 05:27:32PM +0200, Konrad Dybcio wrote:
> >> On 27.08.2024 9:27 AM, Jie Gan wrote:
> >>> Add coresight components for x1e80100. This change includes CTI,
> >>> dummy sink, dynamic Funnel, Replicator, STM, TPDM, TPDA and TMC ETF.
> >>>
> >>> Change in V1:
> >>> Check the dtb with dtbs_check W=1, and fix the warnings for
> >>> the change.
> >>>
> >>
> >> Applying this series and enabling CORESIGHT=m (along with all the options
> >> in menuconfig) breaks booting on my X1E Surface Laptop 7
> >>
> >> Konrad
> > 
> > Did not observe any booting issues with our devices. Any relevant log to share?
> > This patch also tested by my colleague.
> > 
> > Can you successfully boot without the patch?
> 
> I think that's the definition of "breaks booting"...
> 
> Best regards,
> Krzysztof
>

You are right. That's a clear expression. what a stupid question for me, lol.

Thanks,
Jie

On 27/08/2024 09:27, Jie Gan wrote:
> Add coresight components for x1e80100. This change includes CTI,
> dummy sink, dynamic Funnel, Replicator, STM, TPDM, TPDA and TMC ETF.
> 
> Change in V1:
> Check the dtb with dtbs_check W=1, and fix the warnings for
> the change.

So this is v2, not v1.

Best regards,
Krzysztof

On Tue, Aug 27, 2024 at 10:02:44AM +0200, Krzysztof Kozlowski wrote:
> On 27/08/2024 09:27, Jie Gan wrote:
> > Add coresight components for x1e80100. This change includes CTI,
> > dummy sink, dynamic Funnel, Replicator, STM, TPDM, TPDA and TMC ETF.
> > 
> > Change in V1:
> > Check the dtb with dtbs_check W=1, and fix the warnings for
> > the change.
> 
> So this is v2, not v1.
> 
Appologize for the mistake of the version number.
Do I need to re-send the patch with V2?

Thanks,
Jie

On 27/08/2024 10:06, JieGan wrote:
> On Tue, Aug 27, 2024 at 10:02:44AM +0200, Krzysztof Kozlowski wrote:
>> On 27/08/2024 09:27, Jie Gan wrote:
>>> Add coresight components for x1e80100. This change includes CTI,
>>> dummy sink, dynamic Funnel, Replicator, STM, TPDM, TPDA and TMC ETF.
>>>
>>> Change in V1:
>>> Check the dtb with dtbs_check W=1, and fix the warnings for
>>> the change.
>>
>> So this is v2, not v1.
>>
> Appologize for the mistake of the version number.
> Do I need to re-send the patch with V2?

Dunno, maybe Bjorn tools will handle this, maybe not.

Best regards,
Krzysztof

On Tue, Aug 27, 2024 at 11:01:15AM +0200, Krzysztof Kozlowski wrote:
> On 27/08/2024 10:06, JieGan wrote:
> > On Tue, Aug 27, 2024 at 10:02:44AM +0200, Krzysztof Kozlowski wrote:
> >> On 27/08/2024 09:27, Jie Gan wrote:
> >>> Add coresight components for x1e80100. This change includes CTI,
> >>> dummy sink, dynamic Funnel, Replicator, STM, TPDM, TPDA and TMC ETF.
> >>>
> >>> Change in V1:
> >>> Check the dtb with dtbs_check W=1, and fix the warnings for
> >>> the change.
> >>
> >> So this is v2, not v1.
> >>
> > Appologize for the mistake of the version number.
> > Do I need to re-send the patch with V2?
> 
> Dunno, maybe Bjorn tools will handle this, maybe not.
> 
Thanks for checking.
I think it's better to wait other feedbacks.
I will send the patch with new version number in a few days if necessary.

Thanks,
Jie