[v1] Fix compatibles for RK3588 VO{0,1}_GRF

[PATCH 1/2] dt-bindings: soc: rockchip: Fix compatibles for RK3588 VO{0,1}_GRF

Posted by Cristian Ciocaltea 1 year, 3 months ago

According to RK3588 TRM, VO0_GRF and VO1_GRF have a similar layout, but
definitely not an identical one, therefore sharing the compatible is not
really justified.

Since currently there is no user of this, hence no ABI break, let's fix
it by providing dedicated strings.

Reported-by: Conor Dooley <conor@kernel.org>
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
---
 Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
index 78c6d5b64138..8fd539125f4a 100644
--- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
+++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
@@ -31,7 +31,8 @@ properties:
               - rockchip,rk3588-pcie3-pipe-grf
               - rockchip,rk3588-usb-grf
               - rockchip,rk3588-usbdpphy-grf
-              - rockchip,rk3588-vo-grf
+              - rockchip,rk3588-vo0-grf
+              - rockchip,rk3588-vo1-grf
               - rockchip,rk3588-vop-grf
               - rockchip,rv1108-usbgrf
           - const: syscon
@@ -261,7 +262,8 @@ allOf:
         compatible:
           contains:
             enum:
-              - rockchip,rk3588-vo-grf
+              - rockchip,rk3588-vo0-grf
+              - rockchip,rk3588-vo1-grf
 
     then:
       required:

-- 
2.46.0

Re: [PATCH 1/2] dt-bindings: soc: rockchip: Fix compatibles for RK3588 VO{0,1}_GRF

Posted by Krzysztof Kozlowski 1 year, 3 months ago

On Tue, Aug 27, 2024 at 02:06:50AM +0300, Cristian Ciocaltea wrote:
> According to RK3588 TRM, VO0_GRF and VO1_GRF have a similar layout, but
> definitely not an identical one, therefore sharing the compatible is not
> really justified.
> 
> Since currently there is no user of this, hence no ABI break, let's fix
> it by providing dedicated strings.
> 
> Reported-by: Conor Dooley <conor@kernel.org>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> ---
>  Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> index 78c6d5b64138..8fd539125f4a 100644
> --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> @@ -31,7 +31,8 @@ properties:
>                - rockchip,rk3588-pcie3-pipe-grf
>                - rockchip,rk3588-usb-grf
>                - rockchip,rk3588-usbdpphy-grf
> -              - rockchip,rk3588-vo-grf

You should deprecate the old one instead (deprecated: true).

Best regards,
Krzysztof

[PATCH 1/2] dt-bindings: soc: rockchip: Fix compatibles for RK3588 VO{0,1}_GRF
[PATCH 2/2] arm64: dts: rockchip: Fix compatibles for RK3588 VO{0,1}_GRF