[PATCH -next 00/12] mfd: Use for_each_child_of_node_scoped()

Jinjie Ruan posted 12 patches 1 year, 3 months ago
There is a newer version of this series
drivers/mfd/max77620.c                          |  5 ++---
drivers/mfd/qcom-spmi-pmic.c                    |  5 +----
drivers/mtd/nand/raw/arasan-nand-controller.c   |  5 ++---
drivers/mtd/nand/raw/cadence-nand-controller.c  |  4 +---
drivers/mtd/nand/raw/marvell_nand.c             | 12 +++---------
drivers/mtd/nand/raw/meson_nand.c               |  4 +---
drivers/mtd/nand/raw/mtk_nand.c                 |  7 ++-----
drivers/mtd/nand/raw/pl35x-nand-controller.c    |  5 ++---
drivers/mtd/nand/raw/renesas-nand-controller.c  | 12 +++---------
drivers/mtd/nand/raw/rockchip-nand-controller.c |  5 ++---
drivers/mtd/nand/raw/stm32_fmc2_nand.c          |  7 ++-----
drivers/mtd/nand/raw/sunxi_nand.c               |  4 +---
12 files changed, 22 insertions(+), 53 deletions(-)
[PATCH -next 00/12] mfd: Use for_each_child_of_node_scoped()
Posted by Jinjie Ruan 1 year, 3 months ago
Use scoped for_each_available_child_of_node_scoped() when iterating over
device nodes to make code a bit simpler.

Jinjie Ruan (12):
  mfd: max77620: Use for_each_child_of_node_scoped()
  mfd: qcom-spmi-pmic: Use for_each_child_of_node_scoped()
  mtd: rawnand: arasan: Use for_each_child_of_node_scoped()
  mtd: rawnand: cadence: Use for_each_child_of_node_scoped()
  mtd: rawnand: pl353: Use for_each_child_of_node_scoped()
  mtd: rawnand: marvell: drm/rockchip: Use
    for_each_child_of_node_scoped()
  mtd: rawnand: rockchip: Use for_each_child_of_node_scoped()
  mtd: rawnand: meson: Use for_each_child_of_node_scoped()
  mtd: rawnand: mtk: Use for_each_child_of_node_scoped()
  mtd: rawnand: renesas: Use for_each_child_of_node_scoped()
  mtd: rawnand: stm32_fmc2: Use for_each_child_of_node_scoped()
  mtd: rawnand: sunxi: Use for_each_child_of_node_scoped()

 drivers/mfd/max77620.c                          |  5 ++---
 drivers/mfd/qcom-spmi-pmic.c                    |  5 +----
 drivers/mtd/nand/raw/arasan-nand-controller.c   |  5 ++---
 drivers/mtd/nand/raw/cadence-nand-controller.c  |  4 +---
 drivers/mtd/nand/raw/marvell_nand.c             | 12 +++---------
 drivers/mtd/nand/raw/meson_nand.c               |  4 +---
 drivers/mtd/nand/raw/mtk_nand.c                 |  7 ++-----
 drivers/mtd/nand/raw/pl35x-nand-controller.c    |  5 ++---
 drivers/mtd/nand/raw/renesas-nand-controller.c  | 12 +++---------
 drivers/mtd/nand/raw/rockchip-nand-controller.c |  5 ++---
 drivers/mtd/nand/raw/stm32_fmc2_nand.c          |  7 ++-----
 drivers/mtd/nand/raw/sunxi_nand.c               |  4 +---
 12 files changed, 22 insertions(+), 53 deletions(-)

-- 
2.34.1
Re: [PATCH -next 00/12] mfd: Use for_each_child_of_node_scoped()
Posted by Krzysztof Kozlowski 1 year, 3 months ago
On 26/08/2024 10:28, Jinjie Ruan wrote:
> Use scoped for_each_available_child_of_node_scoped() when iterating over
> device nodes to make code a bit simpler.
> 
> Jinjie Ruan (12):
>   mfd: max77620: Use for_each_child_of_node_scoped()
>   mfd: qcom-spmi-pmic: Use for_each_child_of_node_scoped()
>   mtd: rawnand: arasan: Use for_each_child_of_node_scoped()


No, you are mixing different subsystems. And even did not care to Cc
their maintainers.

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.
</form letter>

Best regards,
Krzysztof
Re: [PATCH -next 00/12] mfd: Use for_each_child_of_node_scoped()
Posted by Jinjie Ruan 1 year, 3 months ago

On 2024/8/26 16:29, Krzysztof Kozlowski wrote:
> On 26/08/2024 10:28, Jinjie Ruan wrote:
>> Use scoped for_each_available_child_of_node_scoped() when iterating over
>> device nodes to make code a bit simpler.
>>
>> Jinjie Ruan (12):
>>   mfd: max77620: Use for_each_child_of_node_scoped()
>>   mfd: qcom-spmi-pmic: Use for_each_child_of_node_scoped()
>>   mtd: rawnand: arasan: Use for_each_child_of_node_scoped()
> 
> 
> No, you are mixing different subsystems. And even did not care to Cc
> their maintainers.

OK, I'll resend them.

> 
> <form letter>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC (and consider --no-git-fallback argument). It might
> happen, that command when run on an older kernel, gives you outdated
> entries. Therefore please be sure you base your patches on recent Linux
> kernel.
> 
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, instead use mainline) or work on fork of kernel
> (don't, instead use mainline). Just use b4 and everything should be
> fine, although remember about `b4 prep --auto-to-cc` if you added new
> patches to the patchset.
> </form letter>

Sorry, the low scrip which wrap the `scripts/get_maintainer.pl` has a bug.

> 
> Best regards,
> Krzysztof
>