From: Haowei Zheng <zhenghaowei@loongson.cn>

Change to use the Loongson UART driver for Loongson-2K2000,
Loongson-2K1000 and Loongson-2K0500.

Signed-off-by: Haowei Zheng <zhenghaowei@loongson.cn>
---
 arch/loongarch/boot/dts/loongson-2k0500.dtsi | 2 +-
 arch/loongarch/boot/dts/loongson-2k1000.dtsi | 2 +-
 arch/loongarch/boot/dts/loongson-2k2000.dtsi | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Changes in V2:

- The compatible property for the UART is changed from "ns16650,loongson"

    to "loongson,ls7a-uart".

Changes in V3:

- Compatible has been modified for a specific SoC.

diff --git a/arch/loongarch/boot/dts/loongson-2k0500.dtsi b/arch/loongarch/boot/dts/loongson-2k0500.dtsi
index 3b38ff8853a7..63c77d70639c 100644
--- a/arch/loongarch/boot/dts/loongson-2k0500.dtsi
+++ b/arch/loongarch/boot/dts/loongson-2k0500.dtsi
@@ -220,7 +220,7 @@ tsensor: thermal-sensor@1fe11500 {
 		};
 
 		uart0: serial@1ff40800 {
-			compatible = "ns16550a";
+			compatible = "loongson,ls2k0500-uart", "loongson,ls7a-uart";
 			reg = <0x0 0x1ff40800 0x0 0x10>;
 			clock-frequency = <100000000>;
 			interrupt-parent = <&eiointc>;
diff --git a/arch/loongarch/boot/dts/loongson-2k1000.dtsi b/arch/loongarch/boot/dts/loongson-2k1000.dtsi
index 92180140eb56..cafb8d13c065 100644
--- a/arch/loongarch/boot/dts/loongson-2k1000.dtsi
+++ b/arch/loongarch/boot/dts/loongson-2k1000.dtsi
@@ -297,7 +297,7 @@ dma-controller@1fe00c40 {
 		};
 
 		uart0: serial@1fe20000 {
-			compatible = "ns16550a";
+			compatible = "loongson,ls2k1000-uart", "loongson,ls7a-uart";
 			reg = <0x0 0x1fe20000 0x0 0x10>;
 			clock-frequency = <125000000>;
 			interrupt-parent = <&liointc0>;
diff --git a/arch/loongarch/boot/dts/loongson-2k2000.dtsi b/arch/loongarch/boot/dts/loongson-2k2000.dtsi
index 0953c5707825..d4fe91af8c07 100644
--- a/arch/loongarch/boot/dts/loongson-2k2000.dtsi
+++ b/arch/loongarch/boot/dts/loongson-2k2000.dtsi
@@ -174,7 +174,7 @@ rtc0: rtc@100d0100 {
 		};
 
 		uart0: serial@1fe001e0 {
-			compatible = "ns16550a";
+			compatible = "loongson,ls2k2000-uart";
 			reg = <0x0 0x1fe001e0 0x0 0x10>;
 			clock-frequency = <100000000>;
 			interrupt-parent = <&liointc>;
-- 
2.43.0

On Mon, Aug 26, 2024 at 10:47:05AM +0800, zhenghaowei@loongson.cn wrote:
> From: Haowei Zheng <zhenghaowei@loongson.cn>
> 
> Change to use the Loongson UART driver for Loongson-2K2000,
> Loongson-2K1000 and Loongson-2K0500.

Why?

That's what commit msg should explain.  This is not bisectable and
breaks users without any reasonable need/explanation.

Best regards,
Krzysztof

在 2024/8/26 14:00, Krzysztof Kozlowski 写道:
> On Mon, Aug 26, 2024 at 10:47:05AM +0800,zhenghaowei@loongson.cn wrote:
>> From: Haowei Zheng<zhenghaowei@loongson.cn>
>>
>> Change to use the Loongson UART driver for Loongson-2K2000,
>> Loongson-2K1000 and Loongson-2K0500.
> Why?
>
> That's what commit msg should explain.  This is not bisectable and
> breaks users without any reasonable need/explanation.
>
> Best regards,
> Krzysztof

I got it, and I will provide detailed explanations like this:

We have provided separate UART drivers for ls2k0500,  ls2k1000, and

ls2k2000, which solves the issue of the full-featured serial port being

unusable. Additionally, we have implemented fractional division

functionality for ls2k2000.


Best regards,

Haowei Zheng

On 26/08/2024 08:54, 郑豪威 wrote:
> 
> 在 2024/8/26 14:00, Krzysztof Kozlowski 写道:
>> On Mon, Aug 26, 2024 at 10:47:05AM +0800,zhenghaowei@loongson.cn wrote:
>>> From: Haowei Zheng<zhenghaowei@loongson.cn>
>>>
>>> Change to use the Loongson UART driver for Loongson-2K2000,
>>> Loongson-2K1000 and Loongson-2K0500.
>> Why?
>>
>> That's what commit msg should explain.  This is not bisectable and
>> breaks users without any reasonable need/explanation.
>>
>> Best regards,
>> Krzysztof
> 
> I got it, and I will provide detailed explanations like this:
> 
> We have provided separate UART drivers for ls2k0500,  ls2k1000, and
> 
> ls2k2000, which solves the issue of the full-featured serial port being
> 
> unusable. Additionally, we have implemented fractional division
> 
> functionality for ls2k2000.

You still break the users. Explain the problem you are fixing. NAK.

Best regards,
Krzysztof