staging: rtl8192e: Fix Assignment operator '=' in rtl_wx.c:681

[PATCH] staging: rtl8192e: Fix Assignment operator '=' in rtl_wx.c:681

Posted by Alien Wesley 1 year, 3 months ago

Separated assignments for pairwise_key_type and group_key_type
in order to silence the following checkpatch warning.

CHECK: Assignment operator '=' should be on the previous line.

Signed-off-by: Alien Wesley <alienwesley51@gmail.com>
---
 drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
index 47f1adf30ab4..2d42e7a5bcdb 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
@@ -677,8 +677,8 @@ static int _rtl92e_wx_set_encode_ext(struct net_device *dev,
 
 		if ((encoding->flags & IW_ENCODE_DISABLED) ||
 		    ext->alg == IW_ENCODE_ALG_NONE) {
-			ieee->pairwise_key_type = ieee->group_key_type
-						= KEY_TYPE_NA;
+			ieee->pairwise_key_type = KEY_TYPE_NA;
+			ieee->group_key_type = KEY_TYPE_NA;
 			rtl92e_cam_reset(dev);
 			memset(priv->rtllib->swcamtable, 0,
 			       sizeof(struct sw_cam_table) * 32);
-- 
2.34.1

Re: [PATCH] staging: rtl8192e: Fix Assignment operator '=' in rtl_wx.c:681

Posted by Greg KH 1 year, 3 months ago

On Sun, Aug 25, 2024 at 01:13:35PM -0300, Alien Wesley wrote:
> Separated assignments for pairwise_key_type and group_key_type
> in order to silence the following checkpatch warning.
> 
> CHECK: Assignment operator '=' should be on the previous line.
> 
> Signed-off-by: Alien Wesley <alienwesley51@gmail.com>

Please do not put line numbers in the subject line.

thanks,

greg k-h

Re: [PATCH] staging: rtl8192e: Fix Assignment operator '=' in rtl_wx.c:681

Posted by Alien Wesley 1 year, 3 months ago

On 8/29/24 06:52, Greg KH wrote:
> On Sun, Aug 25, 2024 at 01:13:35PM -0300, Alien Wesley wrote:
>> Separated assignments for pairwise_key_type and group_key_type
>> in order to silence the following checkpatch warning.
>>
>> CHECK: Assignment operator '=' should be on the previous line.
>>
>> Signed-off-by: Alien Wesley <alienwesley51@gmail.com>
> Please do not put line numbers in the subject line.
>
> thanks,
>
> greg k-h

Should I fix up the subject and resend it as v2?

Alien Wesley

Re: [PATCH] staging: rtl8192e: Fix Assignment operator '=' in rtl_wx.c:681

Posted by Dan Carpenter 1 year, 3 months ago

On Thu, Aug 29, 2024 at 08:33:41AM -0300, Alien Wesley wrote:
> On 8/29/24 06:52, Greg KH wrote:
> > On Sun, Aug 25, 2024 at 01:13:35PM -0300, Alien Wesley wrote:
> > > Separated assignments for pairwise_key_type and group_key_type
> > > in order to silence the following checkpatch warning.
> > > 
> > > CHECK: Assignment operator '=' should be on the previous line.
> > > 
> > > Signed-off-by: Alien Wesley <alienwesley51@gmail.com>
> > Please do not put line numbers in the subject line.
> > 
> > thanks,
> > 
> > greg k-h
> 
> Should I fix up the subject and resend it as v2?

Yes.

regards,
dan carpenter

Re: [PATCH] staging: rtl8192e: Fix Assignment operator '=' in rtl_wx.c:681

Posted by Greg KH 1 year, 3 months ago

On Thu, Aug 29, 2024 at 08:33:41AM -0300, Alien Wesley wrote:
> On 8/29/24 06:52, Greg KH wrote:
> > On Sun, Aug 25, 2024 at 01:13:35PM -0300, Alien Wesley wrote:
> > > Separated assignments for pairwise_key_type and group_key_type
> > > in order to silence the following checkpatch warning.
> > > 
> > > CHECK: Assignment operator '=' should be on the previous line.
> > > 
> > > Signed-off-by: Alien Wesley <alienwesley51@gmail.com>
> > Please do not put line numbers in the subject line.
> > 
> > thanks,
> > 
> > greg k-h
> 
> Should I fix up the subject and resend it as v2?

Please do.

Re: [PATCH] staging: rtl8192e: Fix Assignment operator '=' in rtl_wx.c:681

Posted by Philipp Hortmann 1 year, 3 months ago

On 8/25/24 18:13, Alien Wesley wrote:
> Separated assignments for pairwise_key_type and group_key_type
> in order to silence the following checkpatch warning.
> 
> CHECK: Assignment operator '=' should be on the previous line.
> 
> Signed-off-by: Alien Wesley <alienwesley51@gmail.com>
> ---
>   drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> index 47f1adf30ab4..2d42e7a5bcdb 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> @@ -677,8 +677,8 @@ static int _rtl92e_wx_set_encode_ext(struct net_device *dev,
>   
>   		if ((encoding->flags & IW_ENCODE_DISABLED) ||
>   		    ext->alg == IW_ENCODE_ALG_NONE) {
> -			ieee->pairwise_key_type = ieee->group_key_type
> -						= KEY_TYPE_NA;
> +			ieee->pairwise_key_type = KEY_TYPE_NA;
> +			ieee->group_key_type = KEY_TYPE_NA;
>   			rtl92e_cam_reset(dev);
>   			memset(priv->rtllib->swcamtable, 0,
>   			       sizeof(struct sw_cam_table) * 32);


Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>