1. Patchew
  2. linux
  3. View series

[PATCH] EDAC/ie31200: Add Kaby Lake-S dual-core host bridge ID

James Ye posted 1 patch 1 year, 3 months ago 
drivers/edac/ie31200_edac.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
[PATCH] EDAC/ie31200: Add Kaby Lake-S dual-core host bridge ID
Posted by James Ye 1 year, 3 months ago 
Add device ID for dual-core Kaby Lake-S processors e.g. i3-7100.

Signed-off-by: James Ye <jye836@gmail.com>
---
 drivers/edac/ie31200_edac.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/edac/ie31200_edac.c b/drivers/edac/ie31200_edac.c
index 9ef13570f2e5..4fc16922dc1a 100644
--- a/drivers/edac/ie31200_edac.c
+++ b/drivers/edac/ie31200_edac.c
@@ -19,7 +19,8 @@
  * 0c04: Xeon E3-1200 v3/4th Gen Core Processor DRAM Controller
  * 0c08: Xeon E3-1200 v3 Processor DRAM Controller
  * 1918: Xeon E3-1200 v5 Skylake Host Bridge/DRAM Registers
- * 5918: Xeon E3-1200 Xeon E3-1200 v6/7th Gen Core Processor Host Bridge/DRAM Registers
+ * 590f: Xeon E3-1200 v6/7th Gen Core Processor Host Bridge/DRAM Registers
+ * 5918: Xeon E3-1200 v6/7th Gen Core Processor Host Bridge/DRAM Registers
  * 190f: 6th Gen Core Dual-Core Processor Host Bridge/DRAM Registers
  * 191f: 6th Gen Core Quad-Core Processor Host Bridge/DRAM Registers
  * 3e..: 8th/9th Gen Core Processor Host Bridge/DRAM Registers
@@ -67,7 +68,8 @@
 #define PCI_DEVICE_ID_INTEL_IE31200_HB_8  0x190F
 #define PCI_DEVICE_ID_INTEL_IE31200_HB_9  0x1918
 #define PCI_DEVICE_ID_INTEL_IE31200_HB_10 0x191F
-#define PCI_DEVICE_ID_INTEL_IE31200_HB_11 0x5918
+#define PCI_DEVICE_ID_INTEL_IE31200_HB_11 0x590f
+#define PCI_DEVICE_ID_INTEL_IE31200_HB_12 0x5918
 
 /* Coffee Lake-S */
 #define PCI_DEVICE_ID_INTEL_IE31200_HB_CFL_MASK 0x3e00
@@ -88,6 +90,7 @@
 	 ((did) == PCI_DEVICE_ID_INTEL_IE31200_HB_9) ||                        \
 	 ((did) == PCI_DEVICE_ID_INTEL_IE31200_HB_10) ||                       \
 	 ((did) == PCI_DEVICE_ID_INTEL_IE31200_HB_11) ||                       \
+	 ((did) == PCI_DEVICE_ID_INTEL_IE31200_HB_12) ||                       \
 	 (((did) & PCI_DEVICE_ID_INTEL_IE31200_HB_CFL_MASK) ==                 \
 	  PCI_DEVICE_ID_INTEL_IE31200_HB_CFL_MASK))
 
@@ -587,6 +590,7 @@ static const struct pci_device_id ie31200_pci_tbl[] = {
 	{ PCI_VEND_DEV(INTEL, IE31200_HB_9),      PCI_ANY_ID, PCI_ANY_ID, 0, 0, IE31200 },
 	{ PCI_VEND_DEV(INTEL, IE31200_HB_10),     PCI_ANY_ID, PCI_ANY_ID, 0, 0, IE31200 },
 	{ PCI_VEND_DEV(INTEL, IE31200_HB_11),     PCI_ANY_ID, PCI_ANY_ID, 0, 0, IE31200 },
+	{ PCI_VEND_DEV(INTEL, IE31200_HB_12),     PCI_ANY_ID, PCI_ANY_ID, 0, 0, IE31200 },
 	{ PCI_VEND_DEV(INTEL, IE31200_HB_CFL_1),  PCI_ANY_ID, PCI_ANY_ID, 0, 0, IE31200 },
 	{ PCI_VEND_DEV(INTEL, IE31200_HB_CFL_2),  PCI_ANY_ID, PCI_ANY_ID, 0, 0, IE31200 },
 	{ PCI_VEND_DEV(INTEL, IE31200_HB_CFL_3),  PCI_ANY_ID, PCI_ANY_ID, 0, 0, IE31200 },
-- 
2.46.0
Re: [PATCH] EDAC/ie31200: Add Kaby Lake-S dual-core host bridge ID
Posted by Borislav Petkov 1 year, 1 month ago 
Jason,

ack/nak?

On Sat, Aug 24, 2024 at 10:06:22PM +1000, James Ye wrote:
> Add device ID for dual-core Kaby Lake-S processors e.g. i3-7100.
> 
> Signed-off-by: James Ye <jye836@gmail.com>
> ---
>  drivers/edac/ie31200_edac.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/edac/ie31200_edac.c b/drivers/edac/ie31200_edac.c
> index 9ef13570f2e5..4fc16922dc1a 100644
> --- a/drivers/edac/ie31200_edac.c
> +++ b/drivers/edac/ie31200_edac.c
> @@ -19,7 +19,8 @@
>   * 0c04: Xeon E3-1200 v3/4th Gen Core Processor DRAM Controller
>   * 0c08: Xeon E3-1200 v3 Processor DRAM Controller
>   * 1918: Xeon E3-1200 v5 Skylake Host Bridge/DRAM Registers
> - * 5918: Xeon E3-1200 Xeon E3-1200 v6/7th Gen Core Processor Host Bridge/DRAM Registers
> + * 590f: Xeon E3-1200 v6/7th Gen Core Processor Host Bridge/DRAM Registers
> + * 5918: Xeon E3-1200 v6/7th Gen Core Processor Host Bridge/DRAM Registers
>   * 190f: 6th Gen Core Dual-Core Processor Host Bridge/DRAM Registers
>   * 191f: 6th Gen Core Quad-Core Processor Host Bridge/DRAM Registers
>   * 3e..: 8th/9th Gen Core Processor Host Bridge/DRAM Registers
> @@ -67,7 +68,8 @@
>  #define PCI_DEVICE_ID_INTEL_IE31200_HB_8  0x190F
>  #define PCI_DEVICE_ID_INTEL_IE31200_HB_9  0x1918
>  #define PCI_DEVICE_ID_INTEL_IE31200_HB_10 0x191F
> -#define PCI_DEVICE_ID_INTEL_IE31200_HB_11 0x5918
> +#define PCI_DEVICE_ID_INTEL_IE31200_HB_11 0x590f
> +#define PCI_DEVICE_ID_INTEL_IE31200_HB_12 0x5918
>  
>  /* Coffee Lake-S */
>  #define PCI_DEVICE_ID_INTEL_IE31200_HB_CFL_MASK 0x3e00
> @@ -88,6 +90,7 @@
>  	 ((did) == PCI_DEVICE_ID_INTEL_IE31200_HB_9) ||                        \
>  	 ((did) == PCI_DEVICE_ID_INTEL_IE31200_HB_10) ||                       \
>  	 ((did) == PCI_DEVICE_ID_INTEL_IE31200_HB_11) ||                       \
> +	 ((did) == PCI_DEVICE_ID_INTEL_IE31200_HB_12) ||                       \
>  	 (((did) & PCI_DEVICE_ID_INTEL_IE31200_HB_CFL_MASK) ==                 \
>  	  PCI_DEVICE_ID_INTEL_IE31200_HB_CFL_MASK))
>  
> @@ -587,6 +590,7 @@ static const struct pci_device_id ie31200_pci_tbl[] = {
>  	{ PCI_VEND_DEV(INTEL, IE31200_HB_9),      PCI_ANY_ID, PCI_ANY_ID, 0, 0, IE31200 },
>  	{ PCI_VEND_DEV(INTEL, IE31200_HB_10),     PCI_ANY_ID, PCI_ANY_ID, 0, 0, IE31200 },
>  	{ PCI_VEND_DEV(INTEL, IE31200_HB_11),     PCI_ANY_ID, PCI_ANY_ID, 0, 0, IE31200 },
> +	{ PCI_VEND_DEV(INTEL, IE31200_HB_12),     PCI_ANY_ID, PCI_ANY_ID, 0, 0, IE31200 },
>  	{ PCI_VEND_DEV(INTEL, IE31200_HB_CFL_1),  PCI_ANY_ID, PCI_ANY_ID, 0, 0, IE31200 },
>  	{ PCI_VEND_DEV(INTEL, IE31200_HB_CFL_2),  PCI_ANY_ID, PCI_ANY_ID, 0, 0, IE31200 },
>  	{ PCI_VEND_DEV(INTEL, IE31200_HB_CFL_3),  PCI_ANY_ID, PCI_ANY_ID, 0, 0, IE31200 },
> -- 
> 2.46.0
> 
> 

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette
Re: [PATCH] EDAC/ie31200: Add Kaby Lake-S dual-core host bridge ID
Posted by Jason Baron 1 year, 1 month ago 
On 11/4/24 11:04 AM, Borislav Petkov wrote:
> !-------------------------------------------------------------------|
>    This Message Is From an External Sender
>    This message came from outside your organization.
> |-------------------------------------------------------------------!
> 
> Jason,
> 
> ack/nak?
> 



Sorry, seems fine...

Acked-by: Jason Baron <jbaron@akamai.com>


Thanks,

-Jason


> On Sat, Aug 24, 2024 at 10:06:22PM +1000, James Ye wrote:
>> Add device ID for dual-core Kaby Lake-S processors e.g. i3-7100.
>>
>> Signed-off-by: James Ye <jye836@gmail.com>
>> ---
>>   drivers/edac/ie31200_edac.c | 8 ++++++--
>>   1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/edac/ie31200_edac.c b/drivers/edac/ie31200_edac.c
>> index 9ef13570f2e5..4fc16922dc1a 100644
>> --- a/drivers/edac/ie31200_edac.c
>> +++ b/drivers/edac/ie31200_edac.c
>> @@ -19,7 +19,8 @@
>>    * 0c04: Xeon E3-1200 v3/4th Gen Core Processor DRAM Controller
>>    * 0c08: Xeon E3-1200 v3 Processor DRAM Controller
>>    * 1918: Xeon E3-1200 v5 Skylake Host Bridge/DRAM Registers
>> - * 5918: Xeon E3-1200 Xeon E3-1200 v6/7th Gen Core Processor Host Bridge/DRAM Registers
>> + * 590f: Xeon E3-1200 v6/7th Gen Core Processor Host Bridge/DRAM Registers
>> + * 5918: Xeon E3-1200 v6/7th Gen Core Processor Host Bridge/DRAM Registers
>>    * 190f: 6th Gen Core Dual-Core Processor Host Bridge/DRAM Registers
>>    * 191f: 6th Gen Core Quad-Core Processor Host Bridge/DRAM Registers
>>    * 3e..: 8th/9th Gen Core Processor Host Bridge/DRAM Registers
>> @@ -67,7 +68,8 @@
>>   #define PCI_DEVICE_ID_INTEL_IE31200_HB_8  0x190F
>>   #define PCI_DEVICE_ID_INTEL_IE31200_HB_9  0x1918
>>   #define PCI_DEVICE_ID_INTEL_IE31200_HB_10 0x191F
>> -#define PCI_DEVICE_ID_INTEL_IE31200_HB_11 0x5918
>> +#define PCI_DEVICE_ID_INTEL_IE31200_HB_11 0x590f
>> +#define PCI_DEVICE_ID_INTEL_IE31200_HB_12 0x5918
>>   
>>   /* Coffee Lake-S */
>>   #define PCI_DEVICE_ID_INTEL_IE31200_HB_CFL_MASK 0x3e00
>> @@ -88,6 +90,7 @@
>>   	 ((did) == PCI_DEVICE_ID_INTEL_IE31200_HB_9) ||                        \
>>   	 ((did) == PCI_DEVICE_ID_INTEL_IE31200_HB_10) ||                       \
>>   	 ((did) == PCI_DEVICE_ID_INTEL_IE31200_HB_11) ||                       \
>> +	 ((did) == PCI_DEVICE_ID_INTEL_IE31200_HB_12) ||                       \
>>   	 (((did) & PCI_DEVICE_ID_INTEL_IE31200_HB_CFL_MASK) ==                 \
>>   	  PCI_DEVICE_ID_INTEL_IE31200_HB_CFL_MASK))
>>   
>> @@ -587,6 +590,7 @@ static const struct pci_device_id ie31200_pci_tbl[] = {
>>   	{ PCI_VEND_DEV(INTEL, IE31200_HB_9),      PCI_ANY_ID, PCI_ANY_ID, 0, 0, IE31200 },
>>   	{ PCI_VEND_DEV(INTEL, IE31200_HB_10),     PCI_ANY_ID, PCI_ANY_ID, 0, 0, IE31200 },
>>   	{ PCI_VEND_DEV(INTEL, IE31200_HB_11),     PCI_ANY_ID, PCI_ANY_ID, 0, 0, IE31200 },
>> +	{ PCI_VEND_DEV(INTEL, IE31200_HB_12),     PCI_ANY_ID, PCI_ANY_ID, 0, 0, IE31200 },
>>   	{ PCI_VEND_DEV(INTEL, IE31200_HB_CFL_1),  PCI_ANY_ID, PCI_ANY_ID, 0, 0, IE31200 },
>>   	{ PCI_VEND_DEV(INTEL, IE31200_HB_CFL_2),  PCI_ANY_ID, PCI_ANY_ID, 0, 0, IE31200 },
>>   	{ PCI_VEND_DEV(INTEL, IE31200_HB_CFL_3),  PCI_ANY_ID, PCI_ANY_ID, 0, 0, IE31200 },
>> -- 
>> 2.46.0
>>
>>
>
Re: [PATCH] EDAC/ie31200: Add Kaby Lake-S dual-core host bridge ID
Posted by Borislav Petkov 1 year, 1 month ago 
On Mon, Nov 04, 2024 at 11:15:49AM -0500, Jason Baron wrote:
> Sorry, seems fine...
> 
> Acked-by: Jason Baron <jbaron@akamai.com>

Queued, thanks.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.