media: siano: Remove unused declarations

[PATCH -next] media: siano: Remove unused declarations

Posted by Yue Haibing 1 year, 5 months ago

There is no caller and implementation in tree, so can remove them.

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 drivers/media/common/siano/smscoreapi.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/media/common/siano/smscoreapi.h b/drivers/media/common/siano/smscoreapi.h
index 3c15082ce0e3..d945a2d6d624 100644
--- a/drivers/media/common/siano/smscoreapi.h
+++ b/drivers/media/common/siano/smscoreapi.h
@@ -1115,12 +1115,6 @@ extern int smsclient_sendrequest(struct smscore_client_t *client,
 extern void smscore_onresponse(struct smscore_device_t *coredev,
 			       struct smscore_buffer_t *cb);
 
-extern int smscore_get_common_buffer_size(struct smscore_device_t *coredev);
-extern int smscore_map_common_buffer(struct smscore_device_t *coredev,
-				      struct vm_area_struct *vma);
-extern int smscore_send_fw_file(struct smscore_device_t *coredev,
-				u8 *ufwbuf, int size);
-
 extern
 struct smscore_buffer_t *smscore_getbuffer(struct smscore_device_t *coredev);
 extern void smscore_putbuffer(struct smscore_device_t *coredev,
-- 
2.34.1

Re: [PATCH -next] media: siano: Remove unused declarations

Posted by Ricardo Ribalda 1 year, 5 months ago

On Fri, 23 Aug 2024 at 11:51, Yue Haibing <yuehaibing@huawei.com> wrote:
>
> There is no caller and implementation in tree, so can remove them.
>
Reviewed-by: Ricardo Ribalda <ribalda@chromium.org>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
>  drivers/media/common/siano/smscoreapi.h | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/media/common/siano/smscoreapi.h b/drivers/media/common/siano/smscoreapi.h
> index 3c15082ce0e3..d945a2d6d624 100644
> --- a/drivers/media/common/siano/smscoreapi.h
> +++ b/drivers/media/common/siano/smscoreapi.h
> @@ -1115,12 +1115,6 @@ extern int smsclient_sendrequest(struct smscore_client_t *client,
>  extern void smscore_onresponse(struct smscore_device_t *coredev,
>                                struct smscore_buffer_t *cb);
>
> -extern int smscore_get_common_buffer_size(struct smscore_device_t *coredev);
> -extern int smscore_map_common_buffer(struct smscore_device_t *coredev,
> -                                     struct vm_area_struct *vma);
> -extern int smscore_send_fw_file(struct smscore_device_t *coredev,
> -                               u8 *ufwbuf, int size);
> -
>  extern
>  struct smscore_buffer_t *smscore_getbuffer(struct smscore_device_t *coredev);
>  extern void smscore_putbuffer(struct smscore_device_t *coredev,
> --
> 2.34.1
>


-- 
Ricardo Ribalda