Hi
On 8/23/24 9:25 AM, Billy Tsai wrote:
> The exit criteria for the DAA should check if the data length is equal to
> 1, instead of checking if the response status is equal to 1.
>
> Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
> ---
> drivers/i3c/master/mipi-i3c-hci/cmd_v1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
> index d97c3175e0e2..6a781f89b0e4 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
> +++ b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
> @@ -339,7 +339,7 @@ static int hci_cmd_v1_daa(struct i3c_hci *hci)
> break;
> }
> if (RESP_STATUS(xfer[0].response) == RESP_ERR_NACK &&
> - RESP_STATUS(xfer[0].response) == 1) {
> + RESP_DATA_LENGTH(xfer->response) == 1) {
> ret = 0; /* no more devices to be assigned */
> break;
> }
Did you accidentally resend this from a local tree? Is this the same
than your commit cbf871e6d8ce ("i3c/master: cmd_v1: Fix the exit
criteria for the daa procedure")?