[PATCH][next] drm/tegra: hdmi: make read-only const array possible_nvram_sizes static

Colin Ian King posted 1 patch 1 year, 5 months ago
drivers/gpu/drm/tegra/hdmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH][next] drm/tegra: hdmi: make read-only const array possible_nvram_sizes static
Posted by Colin Ian King 1 year, 5 months ago
Don't populate the const read-only array possible_nvram_sizes on the
stack at run time, instead make it static.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/gpu/drm/tegra/hdmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/tegra/hdmi.c b/drivers/gpu/drm/tegra/hdmi.c
index 09987e372e3e..6bf2dae82ca0 100644
--- a/drivers/gpu/drm/tegra/hdmi.c
+++ b/drivers/gpu/drm/tegra/hdmi.c
@@ -434,7 +434,7 @@ tegra_hdmi_get_audio_config(unsigned int audio_freq, unsigned int pix_clock,
 
 static void tegra_hdmi_setup_audio_fs_tables(struct tegra_hdmi *hdmi)
 {
-	const unsigned int freqs[] = {
+	static const unsigned int freqs[] = {
 		32000, 44100, 48000, 88200, 96000, 176400, 192000
 	};
 	unsigned int i;
-- 
2.39.2
Re: [PATCH][next] drm/tegra: hdmi: make read-only const array possible_nvram_sizes static
Posted by Thierry Reding 1 year, 5 months ago
On Thu, Aug 22, 2024 at 09:50:47PM GMT, Colin Ian King wrote:
> Don't populate the const read-only array possible_nvram_sizes on the

I've changed this (and the occurrence in the subject) to reflect the
actual array name ("freqs") that's being changed here.

Applied, thanks.

Thierry
Re: [PATCH][next] drm/tegra: hdmi: make read-only const array possible_nvram_sizes static
Posted by Colin King (gmail) 1 year, 5 months ago
On 29/08/2024 16:50, Thierry Reding wrote:
> On Thu, Aug 22, 2024 at 09:50:47PM GMT, Colin Ian King wrote:
>> Don't populate the const read-only array possible_nvram_sizes on the
> 
> I've changed this (and the occurrence in the subject) to reflect the
> actual array name ("freqs") that's being changed here.

Thanks, my bad.

Colin

> 
> Applied, thanks.
> 
> Thierry