[v2] drivers:block:Use IS_ERR() to check debugfs_create_dir() return value

[PATCH v2] drivers:block:Use IS_ERR() to check debugfs_create_dir() return value

Posted by Yang Ruibin 1 year, 5 months ago

The debugfs_create_dir() function returns error pointers.It
never returns NULL. So use IS_ERR() to check its return value.

Fixes: 011d82611172 ("RAS: Add a Corrected Errors Collector")
Signed-off-by: Yang Ruibin <11162571@vivo.com>
---
 drivers/ras/cec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c
index e440b15fbabc..ebd4631b685b 100644
--- a/drivers/ras/cec.c
+++ b/drivers/ras/cec.c
@@ -489,7 +489,7 @@ static int __init create_debugfs_nodes(void)
 	}
 
 	d = debugfs_create_dir("cec", dfs);
-	if (!d) {
+	if (IS_ERR(d)) {
 		pr_warn("Error creating cec debugfs node!\n");
 		return -1;
 	}
-- 
2.34.1

Re: [PATCH v2] drivers:block:Use IS_ERR() to check debugfs_create_dir() return value

Posted by Jonathan Cameron 1 year, 5 months ago

On Thu, 22 Aug 2024 21:23:58 +0800
Yang Ruibin <11162571@vivo.com> wrote:

Patch title needs an update as this isn't in block and that's not the
style used for this subsystem.

Otherwise fine.

> The debugfs_create_dir() function returns error pointers.It
> never returns NULL. So use IS_ERR() to check its return value.
> 
> Fixes: 011d82611172 ("RAS: Add a Corrected Errors Collector")
> Signed-off-by: Yang Ruibin <11162571@vivo.com>
> ---
>  drivers/ras/cec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c
> index e440b15fbabc..ebd4631b685b 100644
> --- a/drivers/ras/cec.c
> +++ b/drivers/ras/cec.c
> @@ -489,7 +489,7 @@ static int __init create_debugfs_nodes(void)
>  	}
>  
>  	d = debugfs_create_dir("cec", dfs);
> -	if (!d) {
> +	if (IS_ERR(d)) {
>  		pr_warn("Error creating cec debugfs node!\n");
>  		return -1;
>  	}