[PATCH v2 2/3] selftests/resctrl: Always initialize ecx to avoid build warnings

Ilpo Järvinen posted 3 patches 1 year, 5 months ago
There is a newer version of this series
[PATCH v2 2/3] selftests/resctrl: Always initialize ecx to avoid build warnings
Posted by Ilpo Järvinen 1 year, 5 months ago
To avoid warnings when __cpuid_count() is an empty stub, always
initialize ecx because it is used in the return statement.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
 tools/testing/selftests/resctrl/cat_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/resctrl/cat_test.c b/tools/testing/selftests/resctrl/cat_test.c
index 51a1cb6aac34..9882c5d19408 100644
--- a/tools/testing/selftests/resctrl/cat_test.c
+++ b/tools/testing/selftests/resctrl/cat_test.c
@@ -290,7 +290,7 @@ static int cat_run_test(const struct resctrl_test *test, const struct user_param
 
 static bool arch_supports_noncont_cat(const struct resctrl_test *test)
 {
-	unsigned int eax, ebx, ecx, edx;
+	unsigned int eax, ebx, ecx = 0, edx;
 
 	switch (get_vendor()) {
 	case ARCH_AMD:
-- 
2.39.2

Re: [PATCH v2 2/3] selftests/resctrl: Always initialize ecx to avoid build warnings
Posted by Reinette Chatre 1 year, 5 months ago
Hi Ilpo,

On 8/22/24 1:11 AM, Ilpo Järvinen wrote:
> To avoid warnings when __cpuid_count() is an empty stub, always
> initialize ecx because it is used in the return statement.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---

Acked-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette