[v1] drm/amd/display: Use max/min macro

[PATCH v1 0/6] drm/amd/display: Use max/min macro

Posted by Yu Jiaoliang 1 year, 5 months ago

*** BLURB HERE ***

Yu Jiaoliang (6):
  drm/amd/display: Use max/min macro
  drm/amd/display: Use max/min macro
  drm/amd/display: Use max/min macro
  drm/amd/display: Use max/min macro
  drm/amd/display: Use max/min macro
  drm/amd/display: Use max/min macro

 drivers/gpu/drm/amd/display/dc/bios/bios_parser.c            | 4 ++--
 drivers/gpu/drm/amd/display/dc/clk_mgr/dcn20/dcn20_clk_mgr.c | 4 +++-
 drivers/gpu/drm/amd/display/dc/core/dc_resource.c            | 4 ++--
 drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c                 | 2 +-
 drivers/gpu/drm/amd/display/dc/spl/dc_spl.c                  | 4 ++--
 drivers/gpu/drm/amd/display/modules/freesync/freesync.c      | 4 ++--
 6 files changed, 12 insertions(+), 10 deletions(-)

-- 
2.34.1

Re: [PATCH v1 0/6] drm/amd/display: Use max/min macro

Posted by Alex Deucher 1 year, 5 months ago

On Thu, Aug 22, 2024 at 2:57 AM Yu Jiaoliang <yujiaoliang@vivo.com> wrote:
>
> *** BLURB HERE ***
>
> Yu Jiaoliang (6):
>   drm/amd/display: Use max/min macro
>   drm/amd/display: Use max/min macro
>   drm/amd/display: Use max/min macro
>   drm/amd/display: Use max/min macro
>   drm/amd/display: Use max/min macro
>   drm/amd/display: Use max/min macro

Is this the preferred kernel coding style for these type of
comparisons?  Otherwise this just seems like a lot of churn for not
much gain.

Alex

>
>  drivers/gpu/drm/amd/display/dc/bios/bios_parser.c            | 4 ++--
>  drivers/gpu/drm/amd/display/dc/clk_mgr/dcn20/dcn20_clk_mgr.c | 4 +++-
>  drivers/gpu/drm/amd/display/dc/core/dc_resource.c            | 4 ++--
>  drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c                 | 2 +-
>  drivers/gpu/drm/amd/display/dc/spl/dc_spl.c                  | 4 ++--
>  drivers/gpu/drm/amd/display/modules/freesync/freesync.c      | 4 ++--
>  6 files changed, 12 insertions(+), 10 deletions(-)
>
> --
> 2.34.1
>

Re: [PATCH v1 0/6] drm/amd/display: Use max/min macro

Posted by 于佼良 1 year, 5 months ago

在 2024/8/22 14:57, Yu Jiaoliang 写道:
> *** BLURB HERE ***
>
> Yu Jiaoliang (6):
>    drm/amd/display: Use max/min macro
>    drm/amd/display: Use max/min macro
>    drm/amd/display: Use max/min macro
>    drm/amd/display: Use max/min macro
>    drm/amd/display: Use max/min macro
>    drm/amd/display: Use max/min macro
>
>   drivers/gpu/drm/amd/display/dc/bios/bios_parser.c            | 4 ++--
>   drivers/gpu/drm/amd/display/dc/clk_mgr/dcn20/dcn20_clk_mgr.c | 4 +++-
>   drivers/gpu/drm/amd/display/dc/core/dc_resource.c            | 4 ++--
>   drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c                 | 2 +-
>   drivers/gpu/drm/amd/display/dc/spl/dc_spl.c                  | 4 ++--
>   drivers/gpu/drm/amd/display/modules/freesync/freesync.c      | 4 ++--
>   6 files changed, 12 insertions(+), 10 deletions(-)
>
Sorry, please ignore this patch for now. As the corresponding header 
file is not included, compilation errors may occur. This patch will be 
updated later.

Br,

Yu