drivers/pinctrl: Switch to use kmemdup_array()

[PATCH v1] drivers/pinctrl: Switch to use kmemdup_array()

Posted by Shen Lichuan 1 year, 5 months ago

Let the kememdup_array() take care about 
multiplication and possible overflows.

Signed-off-by: Shen Lichuan <shenlichuan@vivo.com>
---
 drivers/pinctrl/pinctrl-utils.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-utils.c b/drivers/pinctrl/pinctrl-utils.c
index d81d7b46116c..f18903de1d71 100644
--- a/drivers/pinctrl/pinctrl-utils.c
+++ b/drivers/pinctrl/pinctrl-utils.c
@@ -70,8 +70,8 @@ int pinctrl_utils_add_map_configs(struct pinctrl_dev *pctldev,
 	if (WARN_ON(*num_maps == *reserved_maps))
 		return -ENOSPC;
 
-	dup_configs = kmemdup(configs, num_configs * sizeof(*dup_configs),
-			      GFP_KERNEL);
+	dup_configs = kmemdup_array(configs, num_configs,
+				sizeof(*dup_configs), GFP_KERNEL);
 	if (!dup_configs)
 		return -ENOMEM;
 
-- 
2.17.1

Re: [PATCH v1] drivers/pinctrl: Switch to use kmemdup_array()

Posted by Linus Walleij 1 year, 5 months ago

On Thu, Aug 22, 2024 at 6:42 AM Shen Lichuan <shenlichuan@vivo.com> wrote:

> Let the kememdup_array() take care about
> multiplication and possible overflows.
>
> Signed-off-by: Shen Lichuan <shenlichuan@vivo.com>

Oh nice patch! Applied!

Yours,
Linus Walleij