[v3] wifi: cfg80211: Use kmemdup_array instead of kmemdup for multiple allocation

[PATCH v3] wifi: cfg80211: Use kmemdup_array instead of kmemdup for multiple allocation

Posted by Yu Jiaoliang 1 year, 5 months ago

Let the kememdup_array() take care about multiplication and possible
overflows.

---
v2:
-Change sizeof(limits[0]) to sizeof(*limits)
-Fix title prefix

v3:
-Fix R-b tag
-Leave --- above this information

Signed-off-by: Yu Jiaoliang <yujiaoliang@vivo.com>
Reviewed-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 net/wireless/util.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/wireless/util.c b/net/wireless/util.c
index 9a7c3adc8a3b..e7c1ac2a0f2d 100644
--- a/net/wireless/util.c
+++ b/net/wireless/util.c
@@ -2435,8 +2435,8 @@ int cfg80211_iter_combinations(struct wiphy *wiphy,
 		if (params->num_different_channels > c->num_different_channels)
 			continue;
 
-		limits = kmemdup(c->limits, sizeof(limits[0]) * c->n_limits,
-				 GFP_KERNEL);
+		limits = kmemdup_array(c->limits, c->n_limits, sizeof(*limits),
+				       GFP_KERNEL);
 		if (!limits)
 			return -ENOMEM;
 
-- 
2.34.1

Re: [PATCH v3] wifi: cfg80211: Use kmemdup_array instead of kmemdup for multiple allocation

Posted by Kalle Valo 1 year, 5 months ago

Yu Jiaoliang <yujiaoliang@vivo.com> writes:

> Let the kememdup_array() take care about multiplication and possible
> overflows.
>
> ---
> v2:
> -Change sizeof(limits[0]) to sizeof(*limits)
> -Fix title prefix
>
> v3:
> -Fix R-b tag
> -Leave --- above this information
>
> Signed-off-by: Yu Jiaoliang <yujiaoliang@vivo.com>
> Reviewed-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Now Signed-off-by and Reviewed-by are in the wrong location. Please
carefully read the wiki page below how to submit patches.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Re: [PATCH v3] wifi: cfg80211: Use kmemdup_array instead of kmemdup for multiple allocation

Posted by 于佼良 1 year, 5 months ago

在 2024/8/22 14:59, Kalle Valo 写道:
> [Some people who received this message don't often get email from kvalo@kernel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> Yu Jiaoliang <yujiaoliang@vivo.com> writes:
>
>> Let the kememdup_array() take care about multiplication and possible
>> overflows.
>>
>> ---
>> v2:
>> -Change sizeof(limits[0]) to sizeof(*limits)
>> -Fix title prefix
>>
>> v3:
>> -Fix R-b tag
>> -Leave --- above this information
>>
>> Signed-off-by: Yu Jiaoliang <yujiaoliang@vivo.com>
>> Reviewed-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> Now Signed-off-by and Reviewed-by are in the wrong location. Please
> carefully read the wiki page below how to submit patches.
>
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

Hi Kalle,

I have updated the position of the changelog and submitted patch v4. 
Thank you.

Best Regards,

Yu