[v1] staging: rtl8192e: Fix alignment parenthesis

[PATCH] staging: rtl8192e: Fix alignment parenthesis

Posted by Nilo Alexandre 1 year, 5 months ago

Fix alignment parenthesis in _rtl92e_read_eeprom_info

CHECK: Alignment should match open parenthesis

Signed-off-by: Nilo Alexandre <n1lux.comp@gmail.com>
---
 drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
index d95807ceed7a6..caaa79935d7da 100644
--- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
+++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
@@ -322,7 +322,7 @@ static void _rtl92e_read_eeprom_info(struct net_device *dev)
 		if (priv->epromtype == EEPROM_93C46) {
 			if (!priv->autoload_fail_flag) {
 				usValue = rtl92e_eeprom_read(dev,
-					                     EEPROM_TxPwDiff_CrystalCap >> 1);
+								EEPROM_TxPwDiff_CrystalCap >> 1);
 				priv->eeprom_ant_pwr_diff = usValue & 0x0fff;
 				priv->eeprom_crystal_cap = (usValue & 0xf000)
 							 >> 12;
-- 
2.46.0

Re: [PATCH] staging: rtl8192e: Fix alignment parenthesis

Posted by Greg Kroah-Hartman 1 year, 5 months ago

On Wed, Aug 21, 2024 at 09:27:00PM -0300, Nilo Alexandre wrote:
> Fix alignment parenthesis in _rtl92e_read_eeprom_info
> 
> CHECK: Alignment should match open parenthesis
> 
> Signed-off-by: Nilo Alexandre <n1lux.comp@gmail.com>
> ---
>  drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> index d95807ceed7a6..caaa79935d7da 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
> @@ -322,7 +322,7 @@ static void _rtl92e_read_eeprom_info(struct net_device *dev)
>  		if (priv->epromtype == EEPROM_93C46) {
>  			if (!priv->autoload_fail_flag) {
>  				usValue = rtl92e_eeprom_read(dev,
> -					                     EEPROM_TxPwDiff_CrystalCap >> 1);
> +								EEPROM_TxPwDiff_CrystalCap >> 1);

The alignment DID match, you just need to use tabs instead of spaces.
Did you run this change through checkpatch.pl after making it to verify
it did what you are saying it did?

thanks,

greg k-h