MAINTAINERS: scale modules with more reviewers

[PATCH] MAINTAINERS: scale modules with more reviewers

Posted by Luis Chamberlain 1 year, 5 months ago

We're looking to add Rust module support, and I don't speak
Rust yet. The compromise was reached that in order to scale we'd
get volunteers committed from the Rust community willing to review
both Rust and C code for modules so we can ensure we get proper
reviews for both parts of the code and so that we can scale.

Add those who have stepped up to help.

Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---

First order of business, please help review Kris Van Hees's patches with
Rust in mind!

 MAINTAINERS | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index f328373463b0..7e2cf251427d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -15454,6 +15454,9 @@ F:	include/dt-bindings/clock/mobileye,eyeq5-clk.h
 
 MODULE SUPPORT
 M:	Luis Chamberlain <mcgrof@kernel.org>
+R:	Petr Pavlu <petr.pavlu@suse.com>
+R:	Sami Tolvanen <samitolvanen@google.com>
+R:	Daniel Gomez <da.gomez@samsung.com>
 L:	linux-modules@vger.kernel.org
 L:	linux-kernel@vger.kernel.org
 S:	Maintained
-- 
2.43.0

Re: [PATCH] MAINTAINERS: scale modules with more reviewers

Posted by Daniel Gomez 1 year, 5 months ago

On Wed, Aug 21, 2024 at 10:40:21AM -0700, Luis Chamberlain wrote:
> We're looking to add Rust module support, and I don't speak
> Rust yet. The compromise was reached that in order to scale we'd
> get volunteers committed from the Rust community willing to review
> both Rust and C code for modules so we can ensure we get proper
> reviews for both parts of the code and so that we can scale.
> 
> Add those who have stepped up to help.
> 
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> ---

Acked-by: Daniel Gomez <da.gomez@samsung.com>

Daniel

> 
> First order of business, please help review Kris Van Hees's patches with
> Rust in mind!
> 
>  MAINTAINERS | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f328373463b0..7e2cf251427d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15454,6 +15454,9 @@ F:	include/dt-bindings/clock/mobileye,eyeq5-clk.h
>  
>  MODULE SUPPORT
>  M:	Luis Chamberlain <mcgrof@kernel.org>
> +R:	Petr Pavlu <petr.pavlu@suse.com>
> +R:	Sami Tolvanen <samitolvanen@google.com>
> +R:	Daniel Gomez <da.gomez@samsung.com>
>  L:	linux-modules@vger.kernel.org
>  L:	linux-kernel@vger.kernel.org
>  S:	Maintained
> -- 
> 2.43.0
>

Re: [PATCH] MAINTAINERS: scale modules with more reviewers

Posted by Petr Pavlu 1 year, 5 months ago

On 8/21/24 19:40, Luis Chamberlain wrote:
> We're looking to add Rust module support, and I don't speak
> Rust yet. The compromise was reached that in order to scale we'd
> get volunteers committed from the Rust community willing to review
> both Rust and C code for modules so we can ensure we get proper
> reviews for both parts of the code and so that we can scale.
> 
> Add those who have stepped up to help.
> 
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>

Acked-by: Petr Pavlu <petr.pavlu@suse.com>

Cheers,
Petr

Re: [PATCH] MAINTAINERS: scale modules with more reviewers

Posted by Sami Tolvanen 1 year, 5 months ago

On Wed, Aug 21, 2024 at 10:40 AM Luis Chamberlain <mcgrof@kernel.org> wrote:
>
> We're looking to add Rust module support, and I don't speak
> Rust yet. The compromise was reached that in order to scale we'd
> get volunteers committed from the Rust community willing to review
> both Rust and C code for modules so we can ensure we get proper
> reviews for both parts of the code and so that we can scale.
>
> Add those who have stepped up to help.
>
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>

Acked-by: Sami Tolvanen <samitolvanen@google.com>

Sami