From: abid-sayyad <sayyad.abid16@gmail.com>

drivers/staging/vt6656/Kconfig

WARNING: please write a help paragraph that fully describes the config symbol
2: FILE: drivers/staging/vt6656/Kconfig:2:
config VT6656
	tristate "VIA Technologies VT6656 support"
	depends on MAC80211 && USB && WLAN && m
	select FW_LOADER
	help

total: 0 errors, 1 warnings, 0 checks, 7 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
   mechanically convert to the typical style using --fix or --fix-inplace.

drivers/staging/vt6656/Kconfig has style problems, please review.


Signed-off-by: abid-sayyad <sayyad.abid16@gmail.com>
---

 drivers/staging/vt6656/Kconfig | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/vt6656/Kconfig b/drivers/staging/vt6656/Kconfig
index f52a3f1d9a2e..a37dc3c921ea 100644
--- a/drivers/staging/vt6656/Kconfig
+++ b/drivers/staging/vt6656/Kconfig
@@ -4,4 +4,10 @@ config VT6656
 	depends on MAC80211 && USB && WLAN && m
 	select FW_LOADER
 	help
-	  This is a vendor-written driver for VIA VT6656.
+	  This is a vendor-written driver for VIA VT6656. VIA Technology VT6656
+	  is a wireless network controller that operates on the 2.4GHz band.
+
+	  If you have this hardware and wish to use it, set 'Y' or 'M' here to
+	  compile the driver either directly in the kernel or as a module
+	  respectively. If you are unsure, it is safe to set it to 'M'.
+	  If enabled it loads the firmware for the mentioned device.
--
2.39.2

On Wed, Aug 21, 2024 at 09:45:39PM +0530, Sayyad Abid wrote:
> From: abid-sayyad <sayyad.abid16@gmail.com>
> 

Your email from header is better than this From header.

> diff --git a/drivers/staging/vt6656/Kconfig b/drivers/staging/vt6656/Kconfig
> index f52a3f1d9a2e..a37dc3c921ea 100644
> --- a/drivers/staging/vt6656/Kconfig
> +++ b/drivers/staging/vt6656/Kconfig
> @@ -4,4 +4,10 @@ config VT6656
>  	depends on MAC80211 && USB && WLAN && m
>  	select FW_LOADER
>  	help
> -	  This is a vendor-written driver for VIA VT6656.
> +	  This is a vendor-written driver for VIA VT6656. VIA Technology VT6656
> +	  is a wireless network controller that operates on the 2.4GHz band.
> +
> +	  If you have this hardware and wish to use it, set 'Y' or 'M' here to
> +	  compile the driver either directly in the kernel or as a module
> +	  respectively. If you are unsure, it is safe to set it to 'M'.
> +	  If enabled it loads the firmware for the mentioned device.

I feel like this second paragraph doesn't add any value.  Just ignore checkpatch
when it tells you to do stuff like this.

regards,
dan carpenter

Also the subject is not in the correct format.

regards,
dan carpenter