The IPQ6005 SoCs and some IPQ6000 SoCs (with PMIC, no fused)[1] have
CPU frequencies up to 1.5GHz, so add this frequency.

[1] Usually the SBL version is BOOT.XF.0.3-00077-IPQ60xxLZB-2
The old version of IPQ6000 did not explicitly fused the SoC to
be 'IPQ6000', and fused the CPU frequency to 1.5GHz.

Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
 arch/arm64/boot/dts/qcom/ipq6018.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
index 1b584d9aadd1..33062417781a 100644
--- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
@@ -140,6 +140,13 @@ opp-1440000000 {
 			clock-latency-ns = <200000>;
 		};
 
+		opp-1512000000 {
+			opp-hz = /bits/ 64 <1512000000>;
+			opp-microvolt = <937500>;
+			opp-supported-hw = <0x2>;
+			clock-latency-ns = <200000>;
+		};
+
 		opp-1608000000 {
 			opp-hz = /bits/ 64 <1608000000>;
 			opp-microvolt = <987500>;
-- 
2.25.1

On Wed, Aug 21, 2024 at 06:10:23PM GMT, Chukun Pan wrote:
> The IPQ6005 SoCs and some IPQ6000 SoCs (with PMIC, no fused)[1] have
> CPU frequencies up to 1.5GHz, so add this frequency.
> 
> [1] Usually the SBL version is BOOT.XF.0.3-00077-IPQ60xxLZB-2
> The old version of IPQ6000 did not explicitly fused the SoC to
> be 'IPQ6000', and fused the CPU frequency to 1.5GHz.

Again, more data is necessary here. "some" doesn't look exact enough.

> 
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
> ---
>  arch/arm64/boot/dts/qcom/ipq6018.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> index 1b584d9aadd1..33062417781a 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> @@ -140,6 +140,13 @@ opp-1440000000 {
>  			clock-latency-ns = <200000>;
>  		};
>  
> +		opp-1512000000 {
> +			opp-hz = /bits/ 64 <1512000000>;
> +			opp-microvolt = <937500>;
> +			opp-supported-hw = <0x2>;
> +			clock-latency-ns = <200000>;
> +		};
> +
>  		opp-1608000000 {
>  			opp-hz = /bits/ 64 <1608000000>;
>  			opp-microvolt = <987500>;
> -- 
> 2.25.1
> 

-- 
With best wishes
Dmitry

Hi,
> You can respond here and post new iteration once we settle on something.

Sorry for the late reply. There are two versions of ipq6000 SoCs:
(1) Earlier version: soc_id: IPQ6018; fuse: BIT(1); SBL version: BOOT.XF.0.3-00077-IPQ60xxLZB-2
(2) Final   version: soc_id: IPQ6000; fuse: BIT(1); SBL version: BOOT.XF.0.3-00086-IPQ60xxLZB-1

The soc_id is related to the sbl version, but it is written by the
manufacturer. On the qsdk kernel, early version could reach 1.5GHz,
while the final version was limited to 1.2GHz.

So I think the commit message can be written like below:

    arm64: dts: qcom: ipq6018: add 1.2GHz CPU Frequency

        The final version of IPQ6000 (soc id: IPQ6000, SBL version:
        BOOT.XF.0.3-00086-IPQ60xxLZB-1) has a max design frequency
        of 1.2GHz, so add this CPU frequency.


    arm64: dts: qcom: ipq6018: add 1.5GHz CPU Frequency

        The early version of IPQ6000 (soc id: IPQ6018, SBL version:
        BOOT.XF.0.3-00086-IPQ60xxLZB-1) and IPQ6005 SoCs can reach
        a max frequency of 1.5GHz, so add this CPU frequency.

Do you think this is appropriate?

Thanks,
Chukun

-- 
2.25.1

On 30.10.2024 2:30 PM, Chukun Pan wrote:
> Hi,
>> You can respond here and post new iteration once we settle on something.
> 
> Sorry for the late reply. There are two versions of ipq6000 SoCs:
> (1) Earlier version: soc_id: IPQ6018; fuse: BIT(1); SBL version: BOOT.XF.0.3-00077-IPQ60xxLZB-2
> (2) Final   version: soc_id: IPQ6000; fuse: BIT(1); SBL version: BOOT.XF.0.3-00086-IPQ60xxLZB-1
> 
> The soc_id is related to the sbl version, but it is written by the
> manufacturer. On the qsdk kernel, early version could reach 1.5GHz,
> while the final version was limited to 1.2GHz.
> 
> So I think the commit message can be written like below:
> 
>     arm64: dts: qcom: ipq6018: add 1.2GHz CPU Frequency
> 
>         The final version of IPQ6000 (soc id: IPQ6000, SBL version:
>         BOOT.XF.0.3-00086-IPQ60xxLZB-1) has a max design frequency
>         of 1.2GHz, so add this CPU frequency.
> 
> 
>     arm64: dts: qcom: ipq6018: add 1.5GHz CPU Frequency
> 
>         The early version of IPQ6000 (soc id: IPQ6018, SBL version:
>         BOOT.XF.0.3-00086-IPQ60xxLZB-1) and IPQ6005 SoCs can reach
>         a max frequency of 1.5GHz, so add this CPU frequency.

Are these earlier versions valid SKUs, or are they something like
engineering samples / early versions that were internal to Qualcomm?

Konrad

Hi,
> Are these earlier versions valid SKUs, or are they something like
> engineering samples / early versions that were internal to Qualcomm?

These early versions are widely used in official products,
such as the Linksys MR7350 and Qihoo 360V6 routers.

Thanks,
Chukun

-- 
2.25.1

>    arm64: dts: qcom: ipq6018: add 1.5GHz CPU Frequency
>
>        The early version of IPQ6000 (soc id: IPQ6018, SBL version:
>        BOOT.XF.0.3-00086-IPQ60xxLZB-1) and IPQ6005 SoCs can reach
>        a max frequency of 1.5GHz, so add this CPU frequency.

SBL version: BOOT.XF.0.3-00077-IPQ60xxLZB-2
Sorry, I made the wrong typo here.

Thanks,
Chukun

-- 
2.25.1