[v1] drivers:mgb4:Fix the NULL vs IS_ERR() bug for debugfs_create_dir()

[PATCH v1] drivers:mgb4:Fix the NULL vs IS_ERR() bug for debugfs_create_dir()

Posted by Yang Ruibin 1 year, 5 months ago

The debugfs_create_dir() function returns error pointers.
It never returns NULL. So use IS_ERR() to check it.

Signed-off-by: Yang Ruibin <11162571@vivo.com>
---
 drivers/media/pci/mgb4/mgb4_vout.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/pci/mgb4/mgb4_vout.c b/drivers/media/pci/mgb4/mgb4_vout.c
index 998edcbd9723..348c8e01fcbe 100644
--- a/drivers/media/pci/mgb4/mgb4_vout.c
+++ b/drivers/media/pci/mgb4/mgb4_vout.c
@@ -683,7 +683,7 @@ static void debugfs_init(struct mgb4_vout_dev *voutdev)
 
 	voutdev->debugfs = debugfs_create_dir(voutdev->vdev.name,
 					      voutdev->mgbdev->debugfs);
-	if (!voutdev->debugfs)
+	if (IS_ERR(voutdev->debugfs))
 		return;
 
 	voutdev->regs[0].name = "CONFIG";
-- 
2.34.1

Re: [PATCH v1] drivers:mgb4:Fix the NULL vs IS_ERR() bug for debugfs_create_dir()

Posted by Martin Tůma 1 year, 5 months ago

On 21. 08. 24 9:10 dop., Yang Ruibin wrote:
> The debugfs_create_dir() function returns error pointers.
> It never returns NULL. So use IS_ERR() to check it.
> 
> Signed-off-by: Yang Ruibin <11162571@vivo.com>
> ---
>   drivers/media/pci/mgb4/mgb4_vout.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/pci/mgb4/mgb4_vout.c b/drivers/media/pci/mgb4/mgb4_vout.c
> index 998edcbd9723..348c8e01fcbe 100644
> --- a/drivers/media/pci/mgb4/mgb4_vout.c
> +++ b/drivers/media/pci/mgb4/mgb4_vout.c
> @@ -683,7 +683,7 @@ static void debugfs_init(struct mgb4_vout_dev *voutdev)
>   
>   	voutdev->debugfs = debugfs_create_dir(voutdev->vdev.name,
>   					      voutdev->mgbdev->debugfs);
> -	if (!voutdev->debugfs)
> +	if (IS_ERR(voutdev->debugfs))
>   		return;
>   
>   	voutdev->regs[0].name = "CONFIG";

Reviewed-by: Martin Tůma <martin.tuma@digiteqautomotive.com>

Re: [PATCH v1] drivers:mgb4:Fix the NULL vs IS_ERR() bug for debugfs_create_dir()

Posted by Martin Tůma 1 year, 5 months ago

On 21. 08. 24 10:56 dop., Martin Tůma wrote:
> On 21. 08. 24 9:10 dop., Yang Ruibin wrote:
>> The debugfs_create_dir() function returns error pointers.
>> It never returns NULL. So use IS_ERR() to check it.
>>
>> Signed-off-by: Yang Ruibin <11162571@vivo.com>
>> ---
>>   drivers/media/pci/mgb4/mgb4_vout.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/pci/mgb4/mgb4_vout.c 
>> b/drivers/media/pci/mgb4/mgb4_vout.c
>> index 998edcbd9723..348c8e01fcbe 100644
>> --- a/drivers/media/pci/mgb4/mgb4_vout.c
>> +++ b/drivers/media/pci/mgb4/mgb4_vout.c
>> @@ -683,7 +683,7 @@ static void debugfs_init(struct mgb4_vout_dev 
>> *voutdev)
>>       voutdev->debugfs = debugfs_create_dir(voutdev->vdev.name,
>>                             voutdev->mgbdev->debugfs);
>> -    if (!voutdev->debugfs)
>> +    if (IS_ERR(voutdev->debugfs))
>>           return;
>>       voutdev->regs[0].name = "CONFIG";
> 
> Reviewed-by: Martin Tůma <martin.tuma@digiteqautomotive.com>
> 
> 

Superseded by
 
https://patchwork.linuxtv.org/project/linux-media/patch/20240826132604.3240-2-tumic@gpxsee.org/
that handles both the input/output device cases as well as an error when 
creating the parent mgb4(PCIe) device.

M.