[v3] drm/i915/gt: Use kmemdup_array instead of kmemdup for multiple allocation

[PATCH v3] drm/i915/gt: Use kmemdup_array instead of kmemdup for multiple allocation

Posted by Yu Jiaoliang 1 year, 5 months ago

Let the kememdup_array() take care about multiplication and possible
overflows.

v2:
- Change subject
- Leave one blank line between the commit log and the tag section
- Fix code alignment issue

v3:
- Fix code alignment
- Apply the patch on a clean drm-tip

Signed-off-by: Yu Jiaoliang <yujiaoliang@vivo.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
---
 drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 09a287c1aedd..3ac0213c711f 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -111,9 +111,8 @@ static void wa_init_finish(struct i915_wa_list *wal)
 {
 	/* Trim unused entries. */
 	if (!IS_ALIGNED(wal->count, WA_LIST_CHUNK)) {
-		struct i915_wa *list = kmemdup(wal->list,
-					       wal->count * sizeof(*list),
-					       GFP_KERNEL);
+		struct i915_wa *list = kmemdup_array(wal->list, wal->count,
+						     sizeof(*list), GFP_KERNEL);
 
 		if (list) {
 			kfree(wal->list);
-- 
2.34.1

Re: [PATCH v3] drm/i915/gt: Use kmemdup_array instead of kmemdup for multiple allocation

Posted by Andi Shyti 1 year, 5 months ago

Hi Yu,

On Wed, Aug 21, 2024 at 10:41:27AM +0800, Yu Jiaoliang wrote:
> Let the kememdup_array() take care about multiplication and possible
> overflows.
> 
> v2:
> - Change subject
> - Leave one blank line between the commit log and the tag section
> - Fix code alignment issue
> 
> v3:
> - Fix code alignment
> - Apply the patch on a clean drm-tip
> 
> Signed-off-by: Yu Jiaoliang <yujiaoliang@vivo.com>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>

merged to drm-intel-gt-next.

Thanks,
Andi

Re: [PATCH v3] drm/i915/gt: Use kmemdup_array instead of kmemdup for multiple allocation

Posted by 于佼良 1 year, 5 months ago

在 2024/8/24 7:32, Andi Shyti 写道:
> [Some people who received this message don't often get email from andi.shyti@linux.intel.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> Hi Yu,
>
> On Wed, Aug 21, 2024 at 10:41:27AM +0800, Yu Jiaoliang wrote:
>> Let the kememdup_array() take care about multiplication and possible
>> overflows.
>>
>> v2:
>> - Change subject
>> - Leave one blank line between the commit log and the tag section
>> - Fix code alignment issue
>>
>> v3:
>> - Fix code alignment
>> - Apply the patch on a clean drm-tip
>>
>> Signed-off-by: Yu Jiaoliang <yujiaoliang@vivo.com>
>> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
> merged to drm-intel-gt-next.
>
> Thanks,
> Andi

Hi Andi,

Thanks for your review.

Best Regards,

Yu